From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simark@simark.ca>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Remove some unnecessary includes from *-exp.y
Date: Mon, 20 Mar 2023 15:22:48 -0600 [thread overview]
Message-ID: <87pm939kyf.fsf@tromey.com> (raw)
In-Reply-To: <d3f69d45-70d3-bcd1-9bd0-28cb8b605966@simark.ca> (Simon Marchi's message of "Mon, 20 Mar 2023 11:45:33 -0400")
Simon> If it builds, it seems fine to me. Those comments (that tell why an
Simon> include is used) almost seem useless to me, as it's nearly impossible to
Simon> maintain them.
Yeah, that is what drew my attention to them.
Simon> It's hard to know if something in these files does need one of the
Simon> headers you remove, and if you now make them rely on indirect
Simon> inclusions.
Also, normally we have headers include their dependencies, so even if
the comments were correct, we'd probably want to patch the header.
This all just looked like copy-paste from ancient times though.
Tom
prev parent reply other threads:[~2023-03-20 21:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-18 14:44 Tom Tromey
2023-03-20 15:45 ` Simon Marchi
2023-03-20 21:22 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pm939kyf.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).