From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 4E8933858C5E for ; Mon, 13 Mar 2023 22:01:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4E8933858C5E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678744880; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AcO9N4zKaDqbpHYhtaJcAB1HV4tGNF7eKHB29OVYyg0=; b=MeRFZCvtBD8ktg/taivBcyj6ugpiFFlmgIaWIZ2i9ZhGNyzQ8x7QLmfimRzCcqFo8pfpRd d47vBt3uLkWgppwwwzMSOs5i15toPCMxO9hQToZYAB0++kmE04X+n1OO4iWOUnMxVydeoy 5eXs4nnGie5mQRPz6lj+uVXtpKjsOWs= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-227-LOzIYqPvMy6zBUudO-9hfA-1; Mon, 13 Mar 2023 18:01:19 -0400 X-MC-Unique: LOzIYqPvMy6zBUudO-9hfA-1 Received: by mail-ed1-f71.google.com with SMTP id z14-20020a05640235ce00b004e07ddbc2f8so18684375edc.7 for ; Mon, 13 Mar 2023 15:01:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678744877; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AcO9N4zKaDqbpHYhtaJcAB1HV4tGNF7eKHB29OVYyg0=; b=ea8+c7p2GSu+EwNzjsGYBPgfd34bnUKq2rZuvyVAGvrGcJoZRyre2dr9gSWKQuFKGQ QJIjVJNwz4JT/ydeko7eBhg/9ONnWqnBxpnYYBJ+JbWMJ16yJIAtRw7zABGuFOTcDKuW jt9AJ8ZY1ATgW/7sLPLRIpdHgyiDG2ey1YQdF/EStXKNtCZeIoy7DTyzI6bxNPEYvGIh 1v/OXfN7cbMtXE7/mo0Cn7Ai1JE08CvNL8XeHiW1Vf5h136KZOH9feAldq05kmG9Or11 IqoPNCmRAZdmfxS1cbfUH4XpZsWu4s2Fkfjawmsp9oIDZjIKzx1k8bcDBk8xIKKzLh+o 82Rw== X-Gm-Message-State: AO0yUKWbOE+el8RaTBzSTw6JTQm+TjCm8FtSZmBo3zNkq2MEmfS+vCYA H2rg4UZLhAjpZ02gHUe7vr2GWwkp/gvs6nIA2DkHGnRyDATkkV3+q8He23mPwrZBDayyz9p4Nb0 wWjLh/eFNiPeCxBaR/cPXyj1OgBtSyA== X-Received: by 2002:a05:6402:690:b0:4ad:7301:fe77 with SMTP id f16-20020a056402069000b004ad7301fe77mr31335430edy.9.1678744877726; Mon, 13 Mar 2023 15:01:17 -0700 (PDT) X-Google-Smtp-Source: AK7set9yt3KqskDgjvsn9YMoVEtPCGzfZQPTuRM1h8PllfjjJVACccUHxIs8Dr0ML2i6owLXZqtC0A== X-Received: by 2002:a05:6402:690:b0:4ad:7301:fe77 with SMTP id f16-20020a056402069000b004ad7301fe77mr31335415edy.9.1678744877445; Mon, 13 Mar 2023 15:01:17 -0700 (PDT) Received: from localhost (95.72.115.87.dyn.plus.net. [87.115.72.95]) by smtp.gmail.com with ESMTPSA id w3-20020a50c443000000b004c30e2fc6e5sm253164edf.65.2023.03.13.15.01.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Mar 2023 15:01:17 -0700 (PDT) From: Andrew Burgess To: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCHv3 0/9] Add new gdbarch::displaced_step_buffer_length field In-Reply-To: References: Date: Mon, 13 Mar 2023 22:01:16 +0000 Message-ID: <87pm9cfh03.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Simon Marchi writes: > On 3/10/23 13:43, Andrew Burgess via Gdb-patches wrote: >> Changes in V3: >> >> - Have now run 'black' on each patch in this series, so everything >> should be formatted correctly, >> >> - Have fixed the out of date names in the last patch of this series. >> Everything buildds and runs fine for me now, >> >> - Have removed the out of date text from the commit message in patch >> #3, >> >> - Have fixed the missing comma Tom spotted in patch #4, >> >> - I have NOT removed the comments Simon pointed out in patch #4. >> Removing these would require changing the generated code for more >> Components than I already change in this commit. And so, I think, >> if those comments are to go that would require a separate patch. >> >> That said, we do generate validation code within the getters for >> many components, so I think having a comment in the components >> where we don't generate validation makes sense. So for me, I >> think the comments do add value, I'd suggest we should keep them. >> >> - And the big one. I've changed the 'invalid' default from False to >> True. I know Simon suggested that False was the correct choice, >> but I actually think that True makes more sense. I'd rather we >> assume we should generate the validity checks and require than new >> components explicitly choose to not have that check, rather than >> just assuming we shouldn't check. >> >> However, in order to get to the default True state I ended up >> having to fix some other issues. And, so, incase people really >> would rather see False as the default, I've left the patch which >> changes to default True as the penultimate patch in the series. >> If you feel really strongly that False is best, I can just drop >> the patch that switches over to use True. Just let me know. >> >> Let me know what you think, >> >> Thanks, >> Andrew > > Thanks Andrew, it all LGTM: > > Approved-By: Simon Marchi Pushed. Thanks, Andrew