From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x134.google.com (mail-il1-x134.google.com [IPv6:2607:f8b0:4864:20::134]) by sourceware.org (Postfix) with ESMTPS id B5065385781F for ; Fri, 17 Feb 2023 14:09:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B5065385781F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-il1-x134.google.com with SMTP id t2so329580ilm.6 for ; Fri, 17 Feb 2023 06:09:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=1xUowEHnRVKrswiSt+OdTYQ/taHlJ6N3k7yXJ9bWS8Y=; b=OtQktBYXpCtVXgYN4VTrS3xc+yc6afQ0UPDTxqYLCI4z4A9Uv9ELsPxlJZ1PLS/RFC v1iNvO6Y9zABHA74iRzrSVv5GtrjG9epWnk41o3Kl3QHab9UfBQMFAtWCWURh215Hpva n+91/IfCqcAm+b3AymMqLmw/xLcfTpNXU+4fmYBEeB1I0ZQqyc3pDv3OhLUv2LoZHL1E 54+yL4bn+nP8Hqs5/34liRAchsKi0batYm1jBt9hgk2W4oNRBxXKZKF3Nq6HIIhtHgWi CLCpKPxrNWU1ej+stGF6zKGHAyJ1D7NT+D1cakD6TfFU2Oz7jZZrQMXpUmN9gY0c7PAA U0RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1xUowEHnRVKrswiSt+OdTYQ/taHlJ6N3k7yXJ9bWS8Y=; b=5NpdmHlD0Dlgo7oufeQovH8HKqljDAmve4bv16LFxIoat4fG6O7O1ge9uUV3sJdbSm RqgMGEEQgyFhrxi7niNBoUy7fD8ZFumAyZGLN0YDAyB41PT4tXVPSDaW5i3a8x5wZu+X qlUp21kh+JFUYQcZ7yjKtjyxPoNjoTHMFg6egkb7iAi3d780e6r9+aEagVAmskZm5FpG jP8VSq8ki/KXxZO9tuufGm7qWetp25gx+/Mja/flrKwGOxCZ5sWWZXPbL7C1Qe+jgwan UxGrsC6xoGXdekqqbo46pX6gfeKsOSoe9pHcIZFWDz+ZicWMPg1k5xp7AhKSEoyQuU2t 1GeQ== X-Gm-Message-State: AO0yUKU5IrSQ/tu2j55MC9wf/zI/iI45kuvSUOQEbvKYLykhatwo+n/5 5FpZ7SdAXQ3puP3CEGhRNBBWwQ== X-Google-Smtp-Source: AK7set+69Kp125AwKYCl1h+hgMYbEpEKxyNBrRw6p+jnmMYRBr0GGSzavYj3D5MU2JbNlYbLX90O1A== X-Received: by 2002:a92:9508:0:b0:313:88cc:26f4 with SMTP id y8-20020a929508000000b0031388cc26f4mr304257ilh.20.1676642963829; Fri, 17 Feb 2023 06:09:23 -0800 (PST) Received: from murgatroyd (75-166-130-93.hlrn.qwest.net. [75.166.130.93]) by smtp.gmail.com with ESMTPSA id r24-20020a028818000000b003a9595b7e3asm1497940jai.46.2023.02.17.06.09.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Feb 2023 06:09:23 -0800 (PST) From: Tom Tromey To: Andrew Burgess Cc: Tom Tromey , Simon Marchi , Tom Tromey via Gdb-patches Subject: Re: [PATCH] Do not record a rejected target description References: <20230112193356.1133696-1-tromey@adacore.com> <87bklwmenh.fsf@redhat.com> <875yc4tawn.fsf@tromey.com> <875yc3m6in.fsf@redhat.com> <871qmqsyvu.fsf@tromey.com> <87zg9do1s6.fsf@tromey.com> <87o7pslhkz.fsf@redhat.com> X-Attribution: Tom Date: Fri, 17 Feb 2023 07:09:22 -0700 In-Reply-To: <87o7pslhkz.fsf@redhat.com> (Andrew Burgess's message of "Fri, 17 Feb 2023 10:19:40 +0000") Message-ID: <87pma8o031.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Andrew" == Andrew Burgess writes: >> -# Required registers are not present so it is expected a warning. >> -# >> -gdb_test "set tdesc filename $srcdir/$subdir/maint_print_struct.xml" " >> -warning:.*" "setting a new tdesc having only a structure" Andrew> Haven't you just deleted a test for a warning here? I thought it was just incidental. I looked at the history of the file and the original commit message only discusses handling the "struct" case. Andrew> I'd propose the patch below. Looks good to me, thanks. Approved-By: Tom Tromey Tom