From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from progateway7-pub.mail.pro1.eigbox.com (gproxy5-pub.mail.unifiedlayer.com [67.222.38.55]) by sourceware.org (Postfix) with ESMTPS id 9E45138555A0 for ; Wed, 15 Feb 2023 16:56:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9E45138555A0 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw10.mail.unifiedlayer.com (unknown [10.0.90.125]) by progateway7.mail.pro1.eigbox.com (Postfix) with ESMTP id A746310048EAD for ; Wed, 15 Feb 2023 16:56:25 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id SL4zpboJuA1zNSL4zpOFDv; Wed, 15 Feb 2023 16:56:25 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=CqN6zl0D c=1 sm=1 tr=0 ts=63ed0eb9 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=m04uMKEZRckA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=qACZJoQXsqzKn9VdhLMA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=GzPbR+QCxadVnC1FbT41hqPspY+r1aic4dZn4OgpHSc=; b=uF7HpuvGto6G3BvERrEaNFJrah 6YFqSz9cwhBi9E6WXa0dapm2FkXDRqux9wVabh0uSx3kBWxJXbaYU60nLsX2+PZCoHZ+69aKCxKsM KwuatrBCDKUYLUA5CcADIXxsh; Received: from 75-166-130-93.hlrn.qwest.net ([75.166.130.93]:37006 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pSL4z-0044Zy-8M; Wed, 15 Feb 2023 09:56:25 -0700 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , Andrew Burgess via Gdb-patches , Andrew Burgess Subject: Re: [PATCH 2/6] Make "ptype INTERNAL_FUNCTION" in Ada print like other languages References: <20230210233604.2228450-1-pedro@palves.net> <20230210233604.2228450-3-pedro@palves.net> <878rh1tuyt.fsf@redhat.com> <87y1p0tgcb.fsf@tromey.com> <0165619c-2905-d164-954b-8a0237d1072b@palves.net> X-Attribution: Tom Date: Wed, 15 Feb 2023 09:56:23 -0700 In-Reply-To: <0165619c-2905-d164-954b-8a0237d1072b@palves.net> (Pedro Alves's message of "Wed, 15 Feb 2023 13:38:58 +0000") Message-ID: <87pmaarhoo.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.130.93 X-Source-L: No X-Exim-ID: 1pSL4z-0044Zy-8M X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-130-93.hlrn.qwest.net (murgatroyd) [75.166.130.93]:37006 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3021.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >> I think this would be better. Pedro> My point with adding this check early is that these functions' type never Pedro> has anything to do with Ada, so all that code at the beginning of ada_print_type, Pedro> like decoded_type_name, ada_is_aligner_type, ada_is_constrained_packed_array_type, Pedro> etc. is always a nop for internal functions, so might as well skip it all. I see. That makes sense to me, thanks. Sorry about the noise, as far as I'm concerned you can land either version of the patch. Pedro> I actually started out by considering moving TYPE_CODE_INTERNAL_FUNCTION printing Pedro> to common code (say, rename the virtual language_defn::print_type to do_print_type, Pedro> and add a new non-virtual wrapper language_defn::print_type method and print Pedro> TYPE_CODE_INTERNAL_FUNCTION there), and I didn't pursue that as I couldn't really convince Pedro> myself that a different language might want to print it differently (say, some other Pedro> characters instead of "<>") I think this is something we can simply force on languages. The type of these things isn't a language feature and probably isn't worth customizing anyway. More generally I think it's better for gdb to try to do more in the common code and leave less to the languages. thanks, Tom