From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x12c.google.com (mail-il1-x12c.google.com [IPv6:2607:f8b0:4864:20::12c]) by sourceware.org (Postfix) with ESMTPS id 1EDEF385843E for ; Wed, 18 Jan 2023 22:02:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1EDEF385843E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-il1-x12c.google.com with SMTP id p12so251687ilq.10 for ; Wed, 18 Jan 2023 14:02:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=rF8f8VGQMCGCHdNe6YpMeI7r4U8ixOTCtnHVHgjqZFs=; b=D4jd6YI8+TJEdrog+TpgEdCZgE4vdyqm4cPX31uMfuzIOeU2oq2GPq//vBsU6X28Lv V1bhEnPh3TQMZaMZcdZZMGab432EBH1IIwH05ZU32jU/QEUP0SOKJG+iYz1x+5LWlAgu kK4cYsPSf4PojFtHlyrxAiTPfYcmx+fwUQDRaxlPmNlb220e6b31QN6X2do6nNl6J7w1 RuIcWIm/R2f9jXxlOsSIwpeeEWSyOJRrUrSYZgf0X0XKHFYrhkrX+6g76IyCjgW/B4uC Q5tulns6Fs9cW+d06Pj8h7aN9QcS6dQDcFtbSRYeaRnaqzibBfX7ekUFODwe/E1VVLM9 HReA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rF8f8VGQMCGCHdNe6YpMeI7r4U8ixOTCtnHVHgjqZFs=; b=r4VXo9l3RmZ+6b4Upz30KKBcB2b6SPIJjWvF8QZO+tLwo0VjmJh51krcbMsToVzoFs NkPIW02yMKx8nTIxZwDx22abg400uJsBD2ftOZBwLyX6QjzfuAGhpUROLkMN+mIBA4fk U77wQMdqSArJd1E4EI+zcp2FraKXyc/iBjvEGPrz3T1DanJJrcmuJWVpM2kpFnriUIDn lUPVgm5a4tpxPGMKyo6Rw+b+Fh2yfM6v07Qe/ETu3fZmjxO46En6yePhXBLLuep13RuG skgrVlr6EWuBg8z57TtO49x+GsAaB+nbUR6UQzDKwxK8OvyREir70xz67UVNFx5TeRlZ IKDg== X-Gm-Message-State: AFqh2koDuoEw+HH025s/V1P0p+o8vTJVxor4OXz9CjNthcQXQvjeEmUc lF1cuJs0wNEwstjDRJd5iQ3MJw== X-Google-Smtp-Source: AMrXdXuHJYubaiFC0qGynw0bpYX+LCu0BcS2kLmIDD51Bij5QA+LHs/1PrdLkNHpFZrUCWjl/oTmVA== X-Received: by 2002:a05:6e02:664:b0:30b:d407:91e1 with SMTP id l4-20020a056e02066400b0030bd40791e1mr7079416ilt.26.1674079365373; Wed, 18 Jan 2023 14:02:45 -0800 (PST) Received: from murgatroyd (97-122-76-186.hlrn.qwest.net. [97.122.76.186]) by smtp.gmail.com with ESMTPSA id r27-20020a02aa1b000000b00346a98b0a76sm10542583jam.77.2023.01.18.14.02.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Jan 2023 14:02:44 -0800 (PST) From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 3/6] Pass section index to start_compunit_symtab References: <20230118153025.342512-1-tromey@adacore.com> <20230118153025.342512-4-tromey@adacore.com> <56ff147d-d09f-2093-efac-50b1eee555d0@simark.ca> X-Attribution: Tom Date: Wed, 18 Jan 2023 15:02:44 -0700 In-Reply-To: <56ff147d-d09f-2093-efac-50b1eee555d0@simark.ca> (Simon Marchi's message of "Wed, 18 Jan 2023 16:55:18 -0500") Message-ID: <87pmbbzekb.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Simon" == Simon Marchi writes: >> + SECTION_INDEX is the index of the section for the compunit and >> + for block symbols in this compunit. Normally SECT_OFF_TEXT. */ Simon> I don't understand this comment, specifically how a compunit can "have" Simon> a single section. Don't compunits define data and text symbols, which Simon> have different sections, for instance? I can reword it, this only refers to the section for blocks. See compunit_symtab::m_block_line_section. Simon> I'm curious to know why we have to store that and we can't always use Simon> SECT_OFF_TEXT, but I guess that will come with the following patches. I suspect this is dead code, I just didn't change it in this series. I could though if you'd prefer. Tom