From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from outbound-ss-820.bluehost.com (outbound-ss-820.bluehost.com [69.89.24.241]) by sourceware.org (Postfix) with ESMTPS id 7B7593858404 for ; Mon, 9 Jan 2023 20:26:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7B7593858404 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw12.mail.unifiedlayer.com (unknown [10.0.90.127]) by progateway2.mail.pro1.eigbox.com (Postfix) with ESMTP id C080410081BEB for ; Mon, 9 Jan 2023 20:26:23 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id EyitpCv07B18UEyitpWjgs; Mon, 09 Jan 2023 20:26:23 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=Ns4Uz+RJ c=1 sm=1 tr=0 ts=63bc786f a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=RvmDmJFTN0MA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=W_PXQr6dQgYpFP6SAS0A:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=hR+LZ/99GtZvmyD9JyJ6r/EqcXoUAjczNgdeZHf9XRo=; b=pD1iG0RyZcKFOdhqLnS6Brjnkr m822ao6/UQwuy1Bshy0+YGryhYjlx3cNGacD/6Ts2tQV1hJAbuDTePqGJxFvIB1mAvTpmcK6oRY7Z oSWawXIZtbhorxf89G6pUVLXT; Received: from 97-122-76-186.hlrn.qwest.net ([97.122.76.186]:44156 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pEyit-003iS5-5u; Mon, 09 Jan 2023 13:26:23 -0700 From: Tom Tromey To: Nils-Christian Kempke via Gdb-patches Cc: Nils-Christian Kempke , aburgess@redhat.com, Tim Wiederhake , Bernhard Heckel , jinisusan.george@amd.com, tom@tromey.com Subject: Re: [PATCH v5 3/3] dwarf, fortran: add support for DW_TAG_entry_point References: <20220808170038.86105-3-nils-christian.kempke@intel.com> <20220808170038.86105-4-nils-christian.kempke@intel.com> X-Attribution: Tom Date: Mon, 09 Jan 2023 13:26:20 -0700 In-Reply-To: <20220808170038.86105-4-nils-christian.kempke@intel.com> (Nils-Christian Kempke via Gdb-patches's message of "Mon, 8 Aug 2022 19:00:38 +0200") Message-ID: <87pmbn8nf7.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.76.186 X-Source-L: No X-Exim-ID: 1pEyit-003iS5-5u X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-76-186.hlrn.qwest.net (murgatroyd) [97.122.76.186]:44156 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> Nils-Christian Kempke via Gdb-patches writes: > const cooked_index_entry *this_parent_entry = parent_entry; > + > + /* The scope of a DW_TAG_entry_point cooked_index_entry is the one of > + its surrounding subroutine. */ > + if (abbrev->tag == DW_TAG_entry_point) > + this_parent_entry = parent_entry->parent_entry; > info_ptr = scan_attributes (reader->cu->per_cu, reader, info_ptr, > info_ptr, abbrev, &name, &linkage_name, > &flags, &sibling, &this_parent_entry, This seems slightly suspect to me but I'm not really sure there's a better way to approach it. Tom