From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x134.google.com (mail-il1-x134.google.com [IPv6:2607:f8b0:4864:20::134]) by sourceware.org (Postfix) with ESMTPS id 7CCB63858D1E for ; Tue, 3 Jan 2023 16:44:03 +0000 (GMT) Received: by mail-il1-x134.google.com with SMTP id bp26so3631168ilb.3 for ; Tue, 03 Jan 2023 08:44:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=rc8VIAmvwV+XdyJxtBm9KtB2R5mLkgTL6BKQHWu224o=; b=bEGf2we1lUNTzOX1KjCzq6BjG5E2348k1TJoFpsFc9uHHu+fqJoCRa8DWauhksRg9u isc0ZosnqT7pAXHHJl44JOixPUZG0Z6+zuH+tXkVR+axM8Nxn3qkHsF70mwDFAhn05ZE OjjG4B5zdDTw7jNtadb+vtQ9e0qPvOP8dO80RKxjT9S8HfF8G9Cvfukh5drAHtwnMJVD j5CjKzALqH7ZvRm+9TfMNwrSS0F/5YnBoMrvqnw6LQCbRCXk7ex0u5GmOC/BezPgSvUS Dbz714HokIiXL9/UDMpONIguL7TVSBY/kvJlYPahJz7cbXOnRkHODZJwnJiKnOw1S1vs kx4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rc8VIAmvwV+XdyJxtBm9KtB2R5mLkgTL6BKQHWu224o=; b=PVamATb/xdEGdXHzXKANMNdN82FdVhUvhd/MEcXgeb7gPA7kdWIg6C+hP2MrS+1HXV 6MhOBfIh6xLmiFFLYlsPqKh7EOe8FxrWbveC3aGaaoKG6UFrx+4jV2mdkx27wjbAhnUx Bh8WqSAhcIo/Pqd0yNc1pf2e/K1E51T5QYiGuOgUAlqQSQgMs6EES5ONtF5rBB+0gnWX vo87BBwjBUN3sCQ84EptbKzl3UvmvmMKxuQ4ml/LNJm43HRzeFgrHhfg1iBYmtuMDvhP qURQCZ9aVXIHOIFoNj0cGRETMzCkXk/Ssn0tEIh7gzCgC+OhtRGFjOUgZH0LhTFsg/Dy RrHg== X-Gm-Message-State: AFqh2kqQIcxVH1SobL/OZ53q42tpqevgxIQ5MJ6hLMOLdc5Gd3HgzppF jDFgEBhEo2OiSUazM27ySdaY/gg+R1YVqGH7 X-Google-Smtp-Source: AMrXdXvCWL7r1xerJF7alM6M0ADJ5ZF88t8rOPpY/dElhOyLw5Mkqj8lO5cXCVuTetjV3h+mVzrbAw== X-Received: by 2002:a92:c151:0:b0:303:6dda:6748 with SMTP id b17-20020a92c151000000b003036dda6748mr29351247ilh.1.1672764242728; Tue, 03 Jan 2023 08:44:02 -0800 (PST) Received: from murgatroyd (97-122-76-186.hlrn.qwest.net. [97.122.76.186]) by smtp.gmail.com with ESMTPSA id i26-20020a02601a000000b0038a47afa8eesm9972612jac.96.2023.01.03.08.44.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Jan 2023 08:44:02 -0800 (PST) From: Tom Tromey To: Tom Tromey via Gdb-patches Cc: Tom Tromey Subject: Re: [PATCH 0/9] Fix "finish" with variably-sized types References: <20221007180120.1866772-1-tromey@adacore.com> X-Attribution: Tom Date: Tue, 03 Jan 2023 09:44:01 -0700 In-Reply-To: <20221007180120.1866772-1-tromey@adacore.com> (Tom Tromey via Gdb-patches's message of "Fri, 7 Oct 2022 12:01:11 -0600") Message-ID: <87pmbvin5a.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom Tromey via Gdb-patches writes: Tom> The "finish" command does not correctly work with variably-sized Tom> types. This affects some Ada programs; I'm not sure whether it can Tom> affect programs written in other languages. Tom> This series fixes the problem, for the architectures I could test. Tom> Patch #2 explains this. Tom> Regression tested on x86-64 Fedora 34. I also ran this through the Tom> AdaCore internal test suite, on all the architectures that are touched Tom> by this series. I've rebased this series. It required one minor change to adapt to some other work in this area. I've re-regression tested it on x86-64 Fedora 36. We've also been using this internally at AdaCore since October or so, regularly testing on all the platforms that are touched by the series. I'm checking it in now. thanks, Tom