From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 4AC703842338 for ; Tue, 6 Dec 2022 17:07:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4AC703842338 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670346436; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PggCkG6pD6dVRvzUXb1OjsYEpxQAvgbKOChzmnvKGf0=; b=VHhj2XFu5dc9KzfqxfsnieAr63JIhcvWXI41jwv3xU/wmAR5wpnWcG0hxNzaoVEYIz89LX a5QxVSMK7Pqh0G0eCRCKhwUu39IBV9S2+swHcZmoEJ9RkSrkmh2mUELq1l5Qi+/NVwqOOn Yw0nmugDJElnuFvr1zVbeCisDnEQiLc= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-670-FR6co6JkNR6a8s6sa1KzKg-1; Tue, 06 Dec 2022 12:07:13 -0500 X-MC-Unique: FR6co6JkNR6a8s6sa1KzKg-1 Received: by mail-wr1-f71.google.com with SMTP id h15-20020adfa4cf000000b0024276cca31cso676328wrb.0 for ; Tue, 06 Dec 2022 09:07:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PggCkG6pD6dVRvzUXb1OjsYEpxQAvgbKOChzmnvKGf0=; b=pZBF95c/gxIXHboRAqLVL7xQf2qvGg2XdmRcdJZKcVXGdeTG0P++zGufKiSTxM60nT UeHS658RZusEbQfbS4F2kSixFeB3dU41H+TLcd3HfgwoaD+8/j93QU9uKfdINck29dGM j90KdXhO+FVcpgR6bKq4karinObIOznQg2o5gaeYnUgqs3jKU1sGmyKKLb+aVIsevbT1 7MILKTPKYz/3jcgNQOOssXr+CxjnmDrt72ijAS+JqHA81tEciLhuJOzr2UACW+NY4l9j hGn7sLbzzoFDvllZ1hdXY0XOMbySMMXsdlxUdb6MztYm+MII6APtsB6j5qd7V5/QHeAu FtQA== X-Gm-Message-State: ANoB5pmU9k7NBHa8YcLgF6jWIXai/gJwJmnktZYkRaqCDVMVrCNkEEvA lSlypKOhXYBHEr5rFLQwBf4dsEN8En0qpUFSJYoAy4EsCTOLCgDcqV0RuqjMRx56G7Oc8rv/A28 sWCWTB7JycnQCh3OAH1vFj1CEsfKo/Hu1+dUqvg7p6mMgK7WHD/HGa3OcfrvLwUWwuMI2LilMlg == X-Received: by 2002:a5d:4308:0:b0:241:e80e:225a with SMTP id h8-20020a5d4308000000b00241e80e225amr37947561wrq.560.1670346432389; Tue, 06 Dec 2022 09:07:12 -0800 (PST) X-Google-Smtp-Source: AA0mqf78kwTzL/cjG7alv1Jgn6nbc99u/kgOdOM5Dqp8m9wYRFafCEInqvDGT/CzLJ3W5fBAypj3pg== X-Received: by 2002:a5d:4308:0:b0:241:e80e:225a with SMTP id h8-20020a5d4308000000b00241e80e225amr37947548wrq.560.1670346432201; Tue, 06 Dec 2022 09:07:12 -0800 (PST) Received: from localhost ([31.111.84.238]) by smtp.gmail.com with ESMTPSA id i14-20020a5d55ce000000b002422816aa25sm20853176wrw.108.2022.12.06.09.07.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Dec 2022 09:07:11 -0800 (PST) From: Andrew Burgess To: Simon Marchi via Gdb-patches , gdb-patches@sourceware.org Cc: Simon Marchi Subject: Re: [PATCH 06/12] gdb: add gdbarch_up In-Reply-To: <20221206135729.3937767-7-simon.marchi@efficios.com> References: <20221206135729.3937767-1-simon.marchi@efficios.com> <20221206135729.3937767-7-simon.marchi@efficios.com> Date: Tue, 06 Dec 2022 17:07:10 +0000 Message-ID: <87pmcw31hd.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Simon Marchi via Gdb-patches writes: > Add a gdbarch_up unique pointer type, that calls gdbarch_free on > deletion. This is used in the ROCm support patch at the end of this > series. LGTM. Thanks, Andrew > > Change-Id: I4b808892d35d69a590ce83180f41afd91705b2c8 > --- > gdb/gdbarch.h | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/gdb/gdbarch.h b/gdb/gdbarch.h > index 196c7981450..d3af5ee00d1 100644 > --- a/gdb/gdbarch.h > +++ b/gdb/gdbarch.h > @@ -306,6 +306,14 @@ extern struct gdbarch *gdbarch_alloc (const struct gdbarch_info *info, > > extern void gdbarch_free (struct gdbarch *); > > +struct gdbarch_deleter > +{ > + void operator() (gdbarch *arch) const > + { gdbarch_free (arch); } > +}; > + > +using gdbarch_up = std::unique_ptr; > + > /* Get the obstack owned by ARCH. */ > > extern obstack *gdbarch_obstack (gdbarch *arch); > -- > 2.38.1