From: Tom Tromey <tom@tromey.com>
To: Tankut Baris Aktemur via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>,
markus.t.metzger@intel.com
Subject: Re: [PATCH] gdbserver: do not report btrace support if target does not announce it
Date: Wed, 09 Nov 2022 08:44:31 -0700 [thread overview]
Message-ID: <87pmdw2kv4.fsf@tromey.com> (raw)
In-Reply-To: <20221109073408.16487-1-tankut.baris.aktemur@intel.com> (Tankut Baris Aktemur via Gdb-patches's message of "Wed, 9 Nov 2022 08:34:08 +0100")
>>>>> Tankut Baris Aktemur via Gdb-patches <gdb-patches@sourceware.org> writes:
> Gdbserver unconditionally reports support for btrace packets. Do not
> report the support, if the underlying target does not say it supports
> it. Otherwise GDB would query the server with btrace-related packets
> unnecessarily.
Looks good to me. Thank you.
Tom
prev parent reply other threads:[~2022-11-09 15:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 7:34 Tankut Baris Aktemur
2022-11-09 15:44 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmdw2kv4.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=markus.t.metzger@intel.com \
--cc=tankut.baris.aktemur@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).