From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 4500F3858D38 for ; Sun, 2 Oct 2022 16:38:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4500F3858D38 Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-550-MOsgSlw-MEu0a5sUPVAqFQ-1; Sun, 02 Oct 2022 12:38:17 -0400 X-MC-Unique: MOsgSlw-MEu0a5sUPVAqFQ-1 Received: by mail-wm1-f72.google.com with SMTP id 7-20020a05600c020700b003b4ce6e6b12so2190194wmi.0 for ; Sun, 02 Oct 2022 09:38:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date; bh=mr/a5M02t6Ffs2yIMC6zLpEWAff2vgE3IViD2OSrCUs=; b=B6RmH9rTr7wf+w58j0HgWOOvUjGYjsPRm/Km7MZspr23hrEBCZXy9rOcAGQYK4hbiN tXRxgN01H7HQcvpaTQy35e1Q0+3sq8EFrkJwd2IE+hERiaOs3s1+ZkydNr3K91vJjrQF DveskhmpjY7jRSuY5jIC2e2T7UtcjPFmAiZftHmz9VmUf+3Sx1qpVL3JnQoLF644So2A QNmobdNgYz5qhgnQW71CiWvHkivOdk814wcT8QCIrVdujvsaHtak28RWRFDlGlQPVO5R BAPESM4K8fike8wPz6BwoIN/Y2h3fchRcU/ji3UXDFlRUQXHuTP+w5+fltTax04tsh7r px8w== X-Gm-Message-State: ACrzQf2tT3E2I/EEVBiPapCGJR5u4bpEIeYtBMQNQAG87Kn+a0sXYqRI RLqiX5Vnz/kRIaJ9PqqbhoVUnkTLXVgyZQrkICa4QeUTEsVP7erYnG0xn06oGSI6q9qQa1RDb29 BuTbyvAlhkG0BSGKWQLVOmz0xdr2Es4vehOrvUfoKmNCM2nw0sR9priu13wubzI3G66/vk0nPTw == X-Received: by 2002:a5d:588f:0:b0:22b:5cc:e1d3 with SMTP id n15-20020a5d588f000000b0022b05cce1d3mr10261793wrf.142.1664728696103; Sun, 02 Oct 2022 09:38:16 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6d4RJppGd60rv7jjGmTBPIo8of97KLu9JMvBu4smBg0IsWXTobhkwL+Qx+pIVgEoWuO8+d+Q== X-Received: by 2002:a5d:588f:0:b0:22b:5cc:e1d3 with SMTP id n15-20020a5d588f000000b0022b05cce1d3mr10261786wrf.142.1664728695838; Sun, 02 Oct 2022 09:38:15 -0700 (PDT) Received: from localhost (52.72.115.87.dyn.plus.net. [87.115.72.52]) by smtp.gmail.com with ESMTPSA id o2-20020a5d62c2000000b0022afce9ea93sm7557514wrv.40.2022.10.02.09.38.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Oct 2022 09:38:15 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Subject: Re: [PATCH 0/3] Improvements for Pygments based disassembly styling In-Reply-To: References: Date: Sun, 02 Oct 2022 17:38:14 +0100 Message-ID: <87pmfagozt.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Oct 2022 16:38:35 -0000 Andrew Burgess writes: > This series was inspired by this stackoverflow post: > > https://stackoverflow.com/questions/73491793/why-is-there-a-%c2%b1-in-lea-rax-rip-%c2%b1-0xeb3 > > which highlighted some issues with the Python Pygments based > disassembler styling that was being used for all architectures in GDB > 12. I've gone ahead and pushed this series. Let me know if anyone runs into any problems. Thanks, Andrew > > The next release of GDB will use libopcodes styling for many of the > most popular architectures, but lots of the smaller architectures are > still using Pygments, and Pygments can still be used for all > architectures if a user chooses to disable use of libopcodes styling, > though I don't know why they would want to do that. > > --- > > Andrew Burgess (3): > gdb/testsuite: extend styling test for libopcodes styling > gdb: improve disassembler styling when Pygments raises an exception > gdb/disasm: better intel flavour disassembly styling with Pygments > > gdb/disasm.c | 69 ++++++++++---- > gdb/disasm.h | 21 +++- > gdb/python/lib/gdb/styling.py | 59 +++++++++++- > gdb/testsuite/gdb.base/style.exp | 159 +++++++++++++++++++++++++------ > 4 files changed, 250 insertions(+), 58 deletions(-) > > -- > 2.25.4