From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 6B1EB385C300 for ; Mon, 12 Sep 2022 09:41:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6B1EB385C300 Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-433-WBOdvfU_MBenTo75iqSvYw-1; Mon, 12 Sep 2022 05:41:15 -0400 X-MC-Unique: WBOdvfU_MBenTo75iqSvYw-1 Received: by mail-wr1-f69.google.com with SMTP id m29-20020adfa3dd000000b00224f577fad1so998533wrb.4 for ; Mon, 12 Sep 2022 02:41:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date; bh=eFnH9VgAXRzLKZHoDQYGGlUFU4NSNGQA5h7xdwTxs9U=; b=Q9I8G4JQw03qjOy2UaNpcFAC0NGwX2nWq4fKm0nsyrbvAJ4RRgzVHj3X35QBOSbDGw lxDK8k0Em8RkiosEqGISOLbTaTWvh4XKEikddakwWrC4BajT28zo9cR5+9xnK3tecx7u 52TRpVRhNGDY29ZzoZf5h6tfzVKKOWu/TOvagP95PuLU0cQZq+Tojo2bV6LvhgL3sgKS 1QWUZn21FfCJq+RTm3aAYOM+reBjASzRDDj2EYAmQZS0lvKbR/dAHNAn1AONzcm5LpaD KVz2tLeLL25muuTQcajt7/uZwpAqbcfNzYoe9RmV0+C8BtNauyiKcP+H8fwzV5qnfMiE Ip6w== X-Gm-Message-State: ACgBeo0cHhsm26Q/7vrz9C+RouXuhk3mBMAX6AbWLI31ZAK90P/aSf6J Yj2Ntzu+ffCgYR7V/34SAhtT14TmGXldZIpgAU7U+oib2yLkA3WDK7xmug55oiYM/0wnB4+L0iX lukMyM4intEMLXckpP0iPhA== X-Received: by 2002:a05:6000:156e:b0:226:f190:448b with SMTP id 14-20020a056000156e00b00226f190448bmr14930274wrz.573.1662975674829; Mon, 12 Sep 2022 02:41:14 -0700 (PDT) X-Google-Smtp-Source: AA6agR4Sznj2OMKgQL8VIIIXr2MGmpRyoIcxa5q11Y7TglAPonjQ1urvyqe9rEG1jJE+GA+j/md3PA== X-Received: by 2002:a05:6000:156e:b0:226:f190:448b with SMTP id 14-20020a056000156e00b00226f190448bmr14930269wrz.573.1662975674585; Mon, 12 Sep 2022 02:41:14 -0700 (PDT) Received: from localhost (52.72.115.87.dyn.plus.net. [87.115.72.52]) by smtp.gmail.com with ESMTPSA id iv11-20020a05600c548b00b003a84375d0d1sm9722076wmb.44.2022.09.12.02.41.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Sep 2022 02:41:14 -0700 (PDT) From: Andrew Burgess To: Bruno Larsen , gdb-patches@sourceware.org Subject: Re: [PATCH v4 06/15] fix gdb.base/access-mem-running.exp for clang testing In-Reply-To: <20220720194441.168906-8-blarsen@redhat.com> References: <20220720194441.168906-1-blarsen@redhat.com> <20220720194441.168906-8-blarsen@redhat.com> Date: Mon, 12 Sep 2022 10:41:13 +0100 Message-ID: <87pmg1kk06.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-10.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2022 09:41:18 -0000 Bruno Larsen via Gdb-patches writes: > Clang was optimizing global_var away because it was not being used > anywhere. this commit fixes that by adding the attribute used it. > --- > gdb/testsuite/gdb.base/access-mem-running.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/testsuite/gdb.base/access-mem-running.c b/gdb/testsuite/gdb.base/access-mem-running.c > index 6335f1bf199..cff6f0da820 100644 > --- a/gdb/testsuite/gdb.base/access-mem-running.c > +++ b/gdb/testsuite/gdb.base/access-mem-running.c > @@ -19,7 +19,7 @@ > > static unsigned int global_counter = 1; > > -static volatile unsigned int global_var = 123; > +static volatile unsigned int __attribute__((used)) global_var = 123; > > static void > maybe_stop_here () LGTM. Feel free to merge this. Thanks, Andrew