Re: [PATCH 5/5] gdbsupport: add path_join function

[Tom Tromey <tom@tromey.com>]

>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:

Simon> If you can make it work using gdb::string_view or const char *, I think
Simon> it would be ok.  I'll give it a try.  But otherwise, I am personally
Simon> fine with the sentinel nullptr, given that the compiler gives you a
Simon> warning if you forget it.

I was also thinking of whether it could be done with string_view.
See the appended for an example.

The benefits of this are that the compiler won't let you pass in
something unless it is convertible to string_view, and also that any
combination of char*, string, and string_view can be passed without
fuss.

Tom

#include <string_view>
#include <array>
#include <string>

void concat (size_t n, const std::string_view *views)
{
  // ...
}

template<typename ...Args>
void
path_join (Args... args)
{
  std::array<std::string_view, sizeof... (Args)> views
    { std::string_view (args)... };
  concat (sizeof... (Args), views.data ());
}

int main () {
  path_join ("a", "b", "c");
  path_join (std::string ("a"), "b");
  return 0;
}