From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from qproxy5-pub.mail.unifiedlayer.com (qproxy5-pub.mail.unifiedlayer.com [69.89.21.30]) by sourceware.org (Postfix) with ESMTPS id 4E5C43858D1E for ; Mon, 18 Apr 2022 20:02:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4E5C43858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from gproxy3-pub.mail.unifiedlayer.com (gproxy3-pub.mail.unifiedlayer.com [69.89.30.42]) by qproxy5.mail.unifiedlayer.com (Postfix) with ESMTP id A30568032AE2 for ; Mon, 18 Apr 2022 20:02:16 +0000 (UTC) Received: from cmgw13.mail.unifiedlayer.com (unknown [10.0.90.128]) by progateway5.mail.pro1.eigbox.com (Postfix) with ESMTP id 66BCB1004878A for ; Mon, 18 Apr 2022 20:01:46 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id gXZBnpJULY8ycgXZCnQnJt; Mon, 18 Apr 2022 20:01:46 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=a8z1SWeF c=1 sm=1 tr=0 ts=625dc3aa a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=z0gMJWrwH1QA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=X7lUt4pTBaj57_GN6KEA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=EKh/yrxV9j5JwEtCCWSIESrqiV4VojV3NUPF9x/qJUs=; b=fEuCwgO2tUvs3tyYnVm9Ymj7mG wZyroViycACicfSOxji530TZ/6McYn+z/mFW98FV2B9kcgRFE4XLSAvuv++ssgoaObMQLZsWc1Mz8 R6OedRlcC0A9guVvBvOc6VDYM; Received: from 71-211-154-204.hlrn.qwest.net ([71.211.154.204]:55630 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ngXZB-004Fgo-Ef; Mon, 18 Apr 2022 14:01:45 -0600 From: Tom Tromey To: Simon Marchi via Gdb-patches Cc: Lancelot SIX , Simon Marchi , Simon Marchi Subject: Re: [PATCH 5/5] gdbsupport: add path_join function References: <20220414200137.3479373-1-simon.marchi@polymtl.ca> <20220414200137.3479373-5-simon.marchi@polymtl.ca> <20220415143827.t2nlcfhmh2pondev@ubuntu.lan> X-Attribution: Tom Date: Mon, 18 Apr 2022 14:01:44 -0600 In-Reply-To: (Simon Marchi via Gdb-patches's message of "Mon, 18 Apr 2022 14:43:08 -0400") Message-ID: <87pmletb2v.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.154.204 X-Source-L: No X-Exim-ID: 1ngXZB-004Fgo-Ef X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-154-204.hlrn.qwest.net (murgatroyd) [71.211.154.204]:55630 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3023.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Apr 2022 20:02:18 -0000 >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> If you can make it work using gdb::string_view or const char *, I think Simon> it would be ok. I'll give it a try. But otherwise, I am personally Simon> fine with the sentinel nullptr, given that the compiler gives you a Simon> warning if you forget it. I was also thinking of whether it could be done with string_view. See the appended for an example. The benefits of this are that the compiler won't let you pass in something unless it is convertible to string_view, and also that any combination of char*, string, and string_view can be passed without fuss. Tom #include #include #include void concat (size_t n, const std::string_view *views) { // ... } template void path_join (Args... args) { std::array views { std::string_view (args)... }; concat (sizeof... (Args), views.data ()); } int main () { path_join ("a", "b", "c"); path_join (std::string ("a"), "b"); return 0; }