From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd34.google.com (mail-io1-xd34.google.com [IPv6:2607:f8b0:4864:20::d34]) by sourceware.org (Postfix) with ESMTPS id CC3233858C56 for ; Mon, 28 Mar 2022 12:42:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CC3233858C56 Received: by mail-io1-xd34.google.com with SMTP id z7so16857800iom.1 for ; Mon, 28 Mar 2022 05:42:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=6IAnqzq4S8S/iovppqtlTFMiolNBizBRwyJnbbEr8H4=; b=pe32Trd/zh3nr9cBDwF9RGiWcexGreS38ApjdNP3C7u2b6jM/zJaPJMTCFX5GemtW2 Ol3Qik+IYmAp9aSnD0dwGWi6tIEX8i8hdi5Uxe4HlTu9qvjPVhTyf5ibN8AU4uEeurHP b4MLVk4X1Rkb+lZjoAOasbUpvnfD6ohF7i1+LVOFjEk03AU3r6yURtHDHTwFyE8BKb46 SXJxVacSDH0lOs2h84PXwMqkVgbLDvf1bC5i+P9CBgtrKIkjmkku9oUcXdIlC0T0rglj Fmh6PZkLgdeWTIUzdAAL48S/Q3Ys73yW552ltNXrBM1AbtrXRp/IoW8lCA2ZD1aGtD6r Q0kQ== X-Gm-Message-State: AOAM530twzm801SJT1AsDs++4NtGvrZo9KsJceMXlePpbL4buMTx98ZB YkU1KIeU4D8iGk/5YqP/84puyPVaWY0IAQ== X-Google-Smtp-Source: ABdhPJx7gSMErp95QVQm6Yun6GG/EMP+gb5G2RTzJ510hGjlWZZyqzKHcRAkMZwr5ThjAzgR9ERmoA== X-Received: by 2002:a02:cd12:0:b0:321:29bd:b5ae with SMTP id g18-20020a02cd12000000b0032129bdb5aemr12449315jaq.83.1648471356002; Mon, 28 Mar 2022 05:42:36 -0700 (PDT) Received: from murgatroyd (71-211-175-224.hlrn.qwest.net. [71.211.175.224]) by smtp.gmail.com with ESMTPSA id c1-20020a92cf41000000b002c8671a801dsm7044173ilr.28.2022.03.28.05.42.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Mar 2022 05:42:35 -0700 (PDT) From: Tom Tromey To: Joel Brobecker via Gdb-patches Cc: Joel Brobecker , Tom Tromey Subject: Re: [PATCH] Don't test interface.exp without GNAT debug info References: <20220317143905.1743262-1-tromey@adacore.com> X-Attribution: Tom Date: Mon, 28 Mar 2022 06:42:35 -0600 In-Reply-To: (Joel Brobecker via Gdb-patches's message of "Sun, 20 Mar 2022 10:02:30 +0400") Message-ID: <87pmm6gsec.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Mar 2022 12:42:38 -0000 >> The test gdb.ada/interface.exp requires some debug info in the GNAT >> runtime. When run without this info, the test can't pass. This patch >> changes the test to detect this situation and stop the test with >> "untested". Joel> Thanks for the patch. It looks good to me. I looked today and found a few more tests that I think fall into this same category, so I updated the patch. Let me know what you think. Tom commit 913bc929e540f5de879f9b20075acbff1183527d Author: Tom Tromey Date: Thu Mar 17 08:36:01 2022 -0600 Require GNAT debug info for some Ada tests A few Ada tests require some debug info in the GNAT runtime. When run without this info, these tests can't pass. This patch changes these tests to detect this situation and stop with "untested". diff --git a/gdb/testsuite/gdb.ada/interface.exp b/gdb/testsuite/gdb.ada/interface.exp index 834da12b153..06b9660113b 100644 --- a/gdb/testsuite/gdb.ada/interface.exp +++ b/gdb/testsuite/gdb.ada/interface.exp @@ -17,6 +17,11 @@ load_lib "ada.exp" if { [skip_ada_tests] } { return -1 } +if {![gnat_runtime_has_debug_info]} { + untested "GNAT runtime debuginfo required for this test" + return -1 +} + standard_ada_testfile foo if {[gdb_compile_ada "${srcfile}" "${binfile}" executable [list debug additional_flags=-gnat05 ]] != "" } { diff --git a/gdb/testsuite/gdb.ada/iwide.exp b/gdb/testsuite/gdb.ada/iwide.exp index 6f522ffb4f3..5d24ae5fd58 100644 --- a/gdb/testsuite/gdb.ada/iwide.exp +++ b/gdb/testsuite/gdb.ada/iwide.exp @@ -17,6 +17,11 @@ load_lib "ada.exp" if { [skip_ada_tests] } { return -1 } +if {![gnat_runtime_has_debug_info]} { + untested "GNAT runtime debuginfo required for this test" + return -1 +} + standard_ada_testfile p if {[gdb_compile_ada "${srcfile}" "${binfile}" executable [list debug additional_flags=-gnat05 ]] != "" } { diff --git a/gdb/testsuite/gdb.ada/mi_interface.exp b/gdb/testsuite/gdb.ada/mi_interface.exp index 89e2fde7b7b..fa176e21ef1 100644 --- a/gdb/testsuite/gdb.ada/mi_interface.exp +++ b/gdb/testsuite/gdb.ada/mi_interface.exp @@ -17,6 +17,11 @@ load_lib "ada.exp" if { [skip_ada_tests] } { return -1 } +if {![gnat_runtime_has_debug_info]} { + untested "GNAT runtime debuginfo required for this test" + return -1 +} + standard_ada_testfile foo if {[gdb_compile_ada "${srcfile}" "${binfile}" executable [list debug additional_flags=-gnat12 ]] != "" } { diff --git a/gdb/testsuite/gdb.ada/tagged.exp b/gdb/testsuite/gdb.ada/tagged.exp index 0e9d15faa0c..6fb8a418149 100644 --- a/gdb/testsuite/gdb.ada/tagged.exp +++ b/gdb/testsuite/gdb.ada/tagged.exp @@ -17,6 +17,11 @@ load_lib "ada.exp" if { [skip_ada_tests] } { return -1 } +if {![gnat_runtime_has_debug_info]} { + untested "GNAT runtime debuginfo required for this test" + return -1 +} + standard_ada_testfile foo if {[gdb_compile_ada "${srcfile}" "${binfile}" executable [list debug]] != "" } { diff --git a/gdb/testsuite/gdb.ada/tagged_access.exp b/gdb/testsuite/gdb.ada/tagged_access.exp index 664a50deb09..3649c5474a7 100644 --- a/gdb/testsuite/gdb.ada/tagged_access.exp +++ b/gdb/testsuite/gdb.ada/tagged_access.exp @@ -17,6 +17,11 @@ load_lib "ada.exp" if { [skip_ada_tests] } { return -1 } +if {![gnat_runtime_has_debug_info]} { + untested "GNAT runtime debuginfo required for this test" + return -1 +} + standard_ada_testfile p if {[gdb_compile_ada "${srcfile}" "${binfile}" executable [list debug]] != "" } {