From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id DEFA4385E02E for ; Mon, 14 Mar 2022 14:13:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DEFA4385E02E Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-364-nT60qx-RNMmWtqqPxJecIA-1; Mon, 14 Mar 2022 10:13:24 -0400 X-MC-Unique: nT60qx-RNMmWtqqPxJecIA-1 Received: by mail-wm1-f71.google.com with SMTP id r133-20020a1c448b000000b00385c3f3defaso5743205wma.3 for ; Mon, 14 Mar 2022 07:13:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=hp5rcqkHD23IUOkX5ZfYfLii8SQwOsavRdkR5yVE5WU=; b=HNY430Xfj01cUg6C5P3Mlq8psVLOnPqh0UdNbBvtkfAIHWh2YPD/lIGyu4HKKVNyxY PM1iTi15Srw3anqYyV5/FGZ2eq1Rtg8m+dev8RYTyrO4LcGPExInk8blSGdpcVvRl8Zw YKi6N5YyoQCKCZQyDKwEJqNOEX7CEBCnA7ZAStGm3Y6tEZOcNBJ45WDKJ5BRytJebn8B /quKgPIu/wtm8ho8WlpmNJkj620tGRAh3hEJ6WdpI6ISMiXY1mFqquMoWPGlvUcwQPSa vuy4aQrb7dQnItzc08AEqR74vvewVQtULSFYuR3I1cIWw+6IR5UOCYRX2aklPLZ+RokC T26Q== X-Gm-Message-State: AOAM5335KL1tEtYU/VHa8BYkSmzRIPdK53J2CH6WsdkZLx5KDbA+Ud28 dMkApuFfHGM4TbeDQiaanhQqIosw1vU1WMXoq1QnFnvwnSEwED/hTmwtLh8dAosYhwtxBpJOn3f svBJ6pkjHHpG5/kom4fhd1yPEWuVC3cSdXSVS7xx93pHTHgImwmQQkiq4pp82Hk9NsakJDxKOIA == X-Received: by 2002:a05:600c:a4b:b0:37b:ea2b:5583 with SMTP id c11-20020a05600c0a4b00b0037bea2b5583mr26325045wmq.139.1647267203378; Mon, 14 Mar 2022 07:13:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyh4Q1XPXluH0+Z1vNoskOW5DjpboGkG0lg5Xdf8NsfOWwnOdO3Uw9N7t82z/x987byQ8yG+Q== X-Received: by 2002:a05:600c:a4b:b0:37b:ea2b:5583 with SMTP id c11-20020a05600c0a4b00b0037bea2b5583mr26325025wmq.139.1647267203066; Mon, 14 Mar 2022 07:13:23 -0700 (PDT) Received: from localhost (host109-154-72-186.range109-154.btcentralplus.com. [109.154.72.186]) by smtp.gmail.com with ESMTPSA id k12-20020adfb34c000000b001f1e13df54dsm13612407wrd.89.2022.03.14.07.13.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Mar 2022 07:13:22 -0700 (PDT) From: Andrew Burgess To: Joel Brobecker via Gdb-patches , Andrew Burgess via Gdb-patches Cc: Jan Vrany , Joel Brobecker Subject: Re: [PATCHv5] gdb/python/mi: create MI commands using python In-Reply-To: References: <20220224103749.1719761-1-aburgess@redhat.com> <20220228164801.1276366-1-aburgess@redhat.com> Date: Mon, 14 Mar 2022 14:13:22 +0000 Message-ID: <87pmmovczh.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Mar 2022 14:13:27 -0000 Joel Brobecker via Gdb-patches writes: > Hi Andrew, > > > On Mon, Feb 28, 2022 at 04:48:01PM +0000, Andrew Burgess via Gdb-patches wrote: >> In v5: >> >> - variable names within the mi output (from Python) can now contain >> the '-' character, >> >> - the example in the docs has been updated to remove the reference >> to an outdated feature (dropped in an earlier version, but the >> example got left in by mistake), >> >> - updated the call to gdbpy_enter to pass no arguments, >> >> - rebased to latest upstream master. > > Now that Tom as confirmed all his comments are approved, can we > push the patch to master? I had been waiting to see if Simon wanted to give any feedback, as he commented on the earlier iterations. But, since his last round of feedback has been addressed, and was pretty minor, I've gone ahead and pushed this patch now. If anything else comes up, then I am, of course, happy to address that in a follow up patch. Thanks, Andrew