From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alt-proxy28.mail.unifiedlayer.com (alt-proxy28.mail.unifiedlayer.com [74.220.216.123]) by sourceware.org (Postfix) with ESMTPS id 3D986385AC21 for ; Fri, 14 Jan 2022 19:52:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3D986385AC21 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw13.mail.unifiedlayer.com (unknown [10.0.90.128]) by progateway1.mail.pro1.eigbox.com (Postfix) with ESMTP id AE84F1003FCED for ; Fri, 14 Jan 2022 19:52:12 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id 8ScOnwv6rEaNC8ScOnptnQ; Fri, 14 Jan 2022 19:52:12 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=dJtjJMVb c=1 sm=1 tr=0 ts=61e1d46c a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=DghFqjY3_ZEA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=13KGAo4DAAAA:8 a=RD8zKJDIhcQQBmhbmc4A:9 a=DdAeqqNASC6T8jxox_Jq:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=HDnJiM4Bm792kDUD/NWem0D57yfxOKNnZ3GoAj+qXms=; b=KANLb/lMWX1VEZlS/i8IGUwrfV h3wYe9HHixBUUV8rkVWPqfzcmtbLbaK8dsoBthE0PxMvfTF50mFT1JpqlzBObESCasEcyOCrTPLrt MeyGe0v54DAFHJ41xl3DKBqrw; Received: from 75-166-134-30.hlrn.qwest.net ([75.166.134.30]:55894 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1n8ScN-0049jo-Uc; Fri, 14 Jan 2022 12:52:12 -0700 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb: split array and string limiting options References: <20211007131451.849029-1-andrew.burgess@embecosm.com> X-Attribution: Tom Date: Fri, 14 Jan 2022 12:52:11 -0700 In-Reply-To: <20211007131451.849029-1-andrew.burgess@embecosm.com> (Andrew Burgess's message of "Thu, 7 Oct 2021 14:14:51 +0100") Message-ID: <87pmouf638.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.134.30 X-Source-L: No X-Exim-ID: 1n8ScN-0049jo-Uc X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-134-30.hlrn.qwest.net (murgatroyd) [75.166.134.30]:55894 X-Source-Auth: tom+tromey.com X-Email-Count: 8 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3025.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Jan 2022 19:52:14 -0000 >>>>> "Andrew" == Andrew Burgess writes: Andrew> This commit splits the set/show print elements options into two. We Andrew> retain set/show print elements for controlling how many elements of an Andrew> array we print, but a new set/show print characters is added which is Andrew> used for controlling how many characters of a string are printed. My apologies for ignoring this for so long. I think it is largely ok -- the one missing thing is that Value.format_string changed, but python.texi was not updated. Perhaps a NEWS entry for this would be needed as well. Andrew> The motivation behind this change is to allow users a finer level of Andrew> control over how data is printed, reflecting that, although strings Andrew> can be thought of as arrays of characters, users often want to treat Andrew> these two things differently. Seems completely reasonable to me. Andrew> There's new tests for Ada and Pascal, as the string printing code for Andrew> these languages is different than the generic string printing code Andrew> used by other languages. Modula2 also has different string printing Andrew> code, but (a) this is similar to Pascal, and (b) there are no existing Andrew> modula2 tests written in Modula2, so I'm not sure how I'd even test Andrew> the Modula2 string printing. Modula2 is maintained on a best-effort basis. Same with Pascal, Objective-C, ... Occasionally I wish all the string-printing code were unified in a nicer way. Rainy day project I guess. thanks, Tom