From: Tom Tromey <tom@tromey.com>
To: Tankut Baris Aktemur via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 3/3] gdb: add the 'set/show suppress-notification-cli' command
Date: Fri, 14 Jan 2022 09:04:24 -0700 [thread overview]
Message-ID: <87pmoui9rr.fsf@tromey.com> (raw)
In-Reply-To: <3a4bd599cabeb95b5f4d18b5d0fb0c24d4bd4266.1638370938.git.tankut.baris.aktemur@intel.com> (Tankut Baris Aktemur via Gdb-patches's message of "Wed, 1 Dec 2021 16:08:29 +0100")
>>>>> ">" == Tankut Baris Aktemur via Gdb-patches <gdb-patches@sourceware.org> writes:
>> GDB already has a flag to suppress printing notification events, such
>> as thread and inferior context switches, on the CLI. This is used
>> internally when executing commands. Make the flag available to the
>> user via a new command. This is expected to be useful in scripts.
Why a "maint" command?
I think in general "maint" should be restricted to things that aren't
useful in any sort of normal way -- commands for gdb developers, or to
change internal settings that we think shouldn't really be changed.
This is reflected in the way that we are more lax about output changes
in maint commands. (FWIW this is why I think we should move the "set
debug" settings under "maint".)
Also this requires a gdb.texinfo update, regardless of the spelling.
And it would be handy to see an example of when you'd want to use this.
thanks,
Tom
next prev parent reply other threads:[~2022-01-14 16:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-01 15:08 [PATCH 0/3] Suppressing CLI notifications Tankut Baris Aktemur
2021-12-01 15:08 ` [PATCH 1/3] gdb/cli: convert cli_suppress_notification from int to bool Tankut Baris Aktemur
2022-01-14 15:52 ` Tom Tromey
2021-12-01 15:08 ` [PATCH 2/3] gdb/cli: add a 'normal_stop' option to 'cli_suppress_notification' Tankut Baris Aktemur
2022-01-14 16:01 ` Tom Tromey
2021-12-01 15:08 ` [PATCH 3/3] gdb: add the 'set/show suppress-notification-cli' command Tankut Baris Aktemur
2022-01-14 16:04 ` Tom Tromey [this message]
2022-01-18 10:41 ` Andrew Burgess
2022-01-14 12:13 ` [PATCH 0/3] Suppressing CLI notifications Aktemur, Tankut Baris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmoui9rr.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).