From: Tom Tromey <tom@tromey.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] C++-ify path substitution code
Date: Sun, 12 Dec 2021 10:56:34 -0700 [thread overview]
Message-ID: <87pmq1yael.fsf@tromey.com> (raw)
In-Reply-To: <YbRVi5WIw6cVOWKn@adacore.com> (Joel Brobecker's message of "Sat, 11 Dec 2021 11:38:51 +0400")
>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
>> I found some uses of xfree in the path substitution code in source.c.
>> C++-ifying struct substitute_path_rule both simplifies the code and
>> removes manual memory management.
Joel> A nice simplification of the code thanks to the C++ std library!
Joel> Just one minor nit that I saw (NULL vs nullptr). Other than that,
Joel> thanks for the reminder-lesson about remove_if! ;-)
>> if (rule == NULL)
Joel> Change that to nullptr?
I am checking it in with this change.
Tom
prev parent reply other threads:[~2021-12-12 17:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-10 19:27 Tom Tromey
2021-12-11 7:38 ` Joel Brobecker
2021-12-12 17:56 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmq1yael.fsf@tromey.com \
--to=tom@tromey.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).