From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy4-pub.mail.unifiedlayer.com (gproxy4-pub.mail.unifiedlayer.com [69.89.23.142]) by sourceware.org (Postfix) with ESMTPS id 1E9793858419 for ; Sun, 12 Dec 2021 17:56:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1E9793858419 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw13.mail.unifiedlayer.com (unknown [10.0.90.128]) by gproxy4.mail.unifiedlayer.com (Postfix) with ESMTP id D98738033229 for ; Sun, 12 Dec 2021 17:56:35 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id wT5PmelUP7Jn4wT5Pmu0N6; Sun, 12 Dec 2021 17:56:35 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=Z+gpoFdA c=1 sm=1 tr=0 ts=61b637d3 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IOMw9HtfNCkA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=A8oJy8mYAAAA:8 a=e_u_65Dc1YcefdIINwgA:9 a=MasS0_dV9q-jaWZIey9J:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=gweDx9JWqAyMb3U7UvI64j6ZdCceYusX5pqjm13nwzI=; b=RBkM7ZfcT/uczxglmnKmdKk8s3 WZENjpwoU+aixc7q09/6489mpyj+ACwOXr80oWe+TLiFBlPtvsB/oz0Q29ZXxkNUQbhozgs3I4CAz MpsBoUv4T/dN+fNq3ZFK517zH; Received: from 75-166-130-34.hlrn.qwest.net ([75.166.130.34]:40468 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mwT5P-0031ey-4Y; Sun, 12 Dec 2021 10:56:35 -0700 From: Tom Tromey To: Joel Brobecker Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] C++-ify path substitution code References: <20211210192749.39983-1-tom@tromey.com> X-Attribution: Tom Date: Sun, 12 Dec 2021 10:56:34 -0700 In-Reply-To: (Joel Brobecker's message of "Sat, 11 Dec 2021 11:38:51 +0400") Message-ID: <87pmq1yael.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.130.34 X-Source-L: No X-Exim-ID: 1mwT5P-0031ey-4Y X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-130-34.hlrn.qwest.net (localhost.localdomain) [75.166.130.34]:40468 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3026.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Dec 2021 17:56:38 -0000 >>>>> "Joel" == Joel Brobecker writes: >> I found some uses of xfree in the path substitution code in source.c. >> C++-ifying struct substitute_path_rule both simplifies the code and >> removes manual memory management. Joel> A nice simplification of the code thanks to the C++ std library! Joel> Just one minor nit that I saw (NULL vs nullptr). Other than that, Joel> thanks for the reminder-lesson about remove_if! ;-) >> if (rule == NULL) Joel> Change that to nullptr? I am checking it in with this change. Tom