From: Tom Tromey <tom@tromey.com>
To: paul-naert via Gdb-patches <gdb-patches@sourceware.org>
Cc: paul-naert <paul_naert@hotmail.fr>
Subject: Re: [RFC][PATCH 2/7] Change memory protection for compile arguments to RW
Date: Fri, 22 May 2020 13:18:51 -0600 [thread overview]
Message-ID: <87pnav4w2s.fsf@tromey.com> (raw)
In-Reply-To: <20200514140849.31845-3-paul_naert@hotmail.fr> (paul-naert via Gdb-patches's message of "Thu, 14 May 2020 10:08:44 -0400")
>>>>> ">" == paul-naert via Gdb-patches <gdb-patches@sourceware.org> writes:
>> The registers need to be updated when gdb_expr is not executed instantly
>> after being compiled, to reflect their values at execution time.
I don't understand the connection between this commit message and what
the patch actually does:
>> + /* Use read-write non-executable memory protection.
>> + We may need to update the registers when calling _gdb_expr_. */
>> regs_addr = gdbarch_infcall_mmap (target_gdbarch (), 0,
>> TYPE_LENGTH (regs_type),
>> - GDB_MMAP_PROT_READ);
>> + GDB_MMAP_PROT_READ | GDB_MMAP_PROT_WRITE);
Tom
next prev parent reply other threads:[~2020-05-22 19:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-14 14:08 [RFC][PATCH 0/7] Patching new code in a binary paul-naert
2020-05-14 14:08 ` [RFC][PATCH 1/7] Add addr argument to infcall_mmap paul-naert
2020-05-14 14:08 ` [RFC][PATCH 2/7] Change memory protection for compile arguments to RW paul-naert
2020-05-22 19:18 ` Tom Tromey [this message]
2020-05-14 14:08 ` [RFC][PATCH 3/7] Make create_sals_from_location_default non static paul-naert
2020-05-14 14:08 ` [RFC][PATCH 4/7] Add address argument to compile_to_object paul-naert
2020-05-14 14:08 ` [RFC][PATCH 5/7] Add the option to defer register storage for compiled object loading paul-naert
2020-05-22 19:39 ` Tom Tromey
2020-05-14 14:08 ` [RFC][PATCH 6/7] Convert short jumps to long ones in amd64_relocate_instruction paul-naert
2020-05-22 19:41 ` Tom Tromey
2020-05-14 14:08 ` [RFC][PATCH 7/7] Add the patch command to dynamically inject code in the inferior paul-naert
2020-05-22 19:50 ` Tom Tromey
2020-05-22 19:57 ` [RFC][PATCH 0/7] Patching new code in a binary Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnav4w2s.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=paul_naert@hotmail.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).