From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: Tom Tromey <tom@tromey.com>,
gdb-patches@sourceware.org, Pedro Alves <palves@redhat.com>
Subject: Re: [PATCH v2 2/2] Add Rust support to source highlighting
Date: Tue, 17 Sep 2019 18:24:00 -0000 [thread overview]
Message-ID: <87pnjywzmz.fsf@tromey.com> (raw)
In-Reply-To: <e7401405-6250-0f4c-25d7-d5e1e58c6b43@suse.de> (Tom de Vries's message of "Thu, 12 Sep 2019 21:20:22 +0200")
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
Tom> Tested on openSUSE Leap 15.1, both with and without source-highlight
Tom> package installed.
Tom> OK for 8.3 branch?
This looks fine to me, but I had two comments.
First, Joel pointed out earlier that backports require a tracking PR, so
be sure to file one and mention it in the commit.
Second, up-thread you said:
Tom> This expection happens when the library attempts to access
Tom> /usr/share/source-highlight/esc.outlang, which is not there, because
Tom> it's contained in another package (source-highlight).
... but the patch does:
Tom> srchilite::SourceHighlight highlighter ("esc.outlang");
Tom> highlighter.setStyleFile("esc.style");
Tom> - std::ostringstream output;
Tom> - highlighter.highlight (input, output, lang_name, fullname);
Tom> + try
Tom> + {
Tom> + std::ostringstream output;
Tom> + highlighter.highlight (input, output, lang_name, fullname);
I am wondering if the "try" should encompass the construction of
"highlighter". It's possible that it works fine as-is, since maybe the
argument isn't used until highlighting is attempted -- but I figured I
would ask just to be sure.
thanks,
Tom
next prev parent reply other threads:[~2019-09-17 18:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-27 15:52 [PATCH v2 0/2] " Tom Tromey
2019-07-27 15:52 ` [PATCH v2 1/2] Add --with-static-standard-libraries to the top level Tom Tromey
2019-07-27 15:52 ` [PATCH v2 2/2] Add Rust support to source highlighting Tom Tromey
2019-09-04 17:22 ` Tom de Vries
2019-09-10 15:56 ` Tom Tromey
2019-09-12 19:20 ` Tom de Vries
2019-09-17 18:24 ` Tom Tromey [this message]
2019-09-18 22:16 ` Tom de Vries
2019-09-19 12:54 ` Tom Tromey
2019-09-19 16:18 ` [PATCH][gdb] Catch exception when constructing the highlighter Tom de Vries
2019-08-19 16:19 ` [PATCH v2 0/2] Add Rust support to source highlighting Tom Tromey
2019-08-19 18:29 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnjywzmz.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).