From: Tom Tromey <tom@tromey.com>
To: Jan Vrany <jan.vrany@fit.cvut.cz>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC 6/8] mi/python: Handle python exception when executiong python-defined MI commands
Date: Thu, 25 Apr 2019 19:46:00 -0000 [thread overview]
Message-ID: <87pnp97tqz.fsf@tromey.com> (raw)
In-Reply-To: <20190418152337.6376-7-jan.vrany@fit.cvut.cz> (Jan Vrany's message of "Thu, 18 Apr 2019 16:23:35 +0100")
>>>>> "Jan" == Jan Vrany <jan.vrany@fit.cvut.cz> writes:
Jan> Respond with ^error,msg="..." when an unhandled python exception is thrown
Jan> while invoking python-defined MI command. The error message is taken from
Jan> python exception object.
Jan> gdb/Changelog:
Jan> * python/py-micmd.c (py_mi_invoke): Handle exceptions thrown in Python
Jan> code.
This seems reasonable but it also seems like it should just be part of
the patch adding this new function. If you're worried about joint
authorship, it's pretty common to just list two names in the ChangeLog.
thanks,
Tom
next prev parent reply other threads:[~2019-04-25 19:46 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-18 15:23 [RFC 0/8] Create MI commands using python Jan Vrany
2019-04-18 15:23 ` [RFC 1/8] Use std::map for MI commands in mi-cmds.c Jan Vrany
2019-04-25 19:13 ` Tom Tromey
2019-04-25 19:15 ` Tom Tromey
2019-04-25 19:34 ` Jan Vrany
2019-05-03 22:40 ` Simon Marchi
2019-05-03 22:45 ` Simon Marchi
2019-04-18 15:24 ` [RFC 7/8] mi/python: Add tests for python-defined MI commands Jan Vrany
2019-04-25 19:48 ` Tom Tromey
2019-04-18 15:24 ` [RFC 8/8] mi/python: Allow redefinition of python " Jan Vrany
2019-04-25 19:50 ` Tom Tromey
2019-05-03 15:26 ` Jan Vrany
2019-05-06 21:40 ` Tom Tromey
2019-05-07 11:26 ` Jan Vrany
2019-05-07 13:09 ` Simon Marchi
2019-05-07 13:19 ` Jan Vrany
2019-05-08 0:10 ` Simon Marchi
2019-05-08 18:00 ` Tom Tromey
2019-04-18 15:24 ` [RFC 6/8] mi/python: Handle python exception when executiong python-defined " Jan Vrany
2019-04-25 19:46 ` Tom Tromey [this message]
2019-04-26 10:19 ` Jan Vrany
2019-04-18 15:24 ` [RFC 2/8] Use classes to represent MI Command instead of structures Jan Vrany
2019-04-25 19:25 ` Tom Tromey
2019-05-03 22:49 ` Simon Marchi
2019-05-03 22:57 ` Simon Marchi
2019-04-18 15:24 ` [RFC 3/8] Create MI commands using python Jan Vrany
2019-04-25 19:42 ` Tom Tromey
2019-04-18 15:24 ` [RFC 4/8] mi/python: C++ify python MI command handling code Jan Vrany
2019-04-25 19:43 ` Tom Tromey
2019-04-18 16:03 ` [RFC 0/8] Create MI commands using python Simon Marchi
2019-04-20 7:20 ` Jan Vrany
2019-04-18 16:12 ` [RFC 5/8] mi/python: Polish MI output of python commands Jan Vrany
2019-04-25 19:50 ` Tom Tromey
2019-04-25 18:03 ` [RFC 0/8] Create MI commands using python Tom Tromey
2019-04-25 19:00 ` Simon Marchi
2019-04-25 19:01 ` Simon Marchi
2019-05-14 11:24 ` [PATCH v2 0/5] " Jan Vrany
2019-05-14 11:24 ` [PATCH v2 2/5] Use classes to represent MI Command instead of structures Jan Vrany
2019-05-17 3:12 ` Simon Marchi
2019-05-14 11:24 ` [PATCH v2 1/5] Use std::map for MI commands in mi-cmds.c Jan Vrany
2019-05-14 11:24 ` [PATCH v2 5/5] mi/python: Add tests for python-defined MI commands Jan Vrany
2019-05-14 11:24 ` [PATCH v2 3/5] Create MI commands using python Jan Vrany
2019-05-17 4:29 ` Simon Marchi
2019-05-28 20:35 ` Jan Vrany
2019-05-14 11:57 ` [PATCH v2 4/5] mi/python: Allow redefinition of python MI commands Jan Vrany
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnp97tqz.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.vrany@fit.cvut.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).