From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15552 invoked by alias); 8 Oct 2018 00:23:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15531 invoked by uid 89); 8 Oct 2018 00:23:20 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=investigation, our, super X-HELO: gateway36.websitewelcome.com Received: from gateway36.websitewelcome.com (HELO gateway36.websitewelcome.com) (192.185.185.36) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 08 Oct 2018 00:23:18 +0000 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 2A3EB400C5EA1 for ; Sun, 7 Oct 2018 18:29:47 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 9JKPgpPt7SjJA9JKPgMpEk; Sun, 07 Oct 2018 19:23:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=zzBmqFYJFEGXBF1RCyLW4+lloxHeSw5vdXaKuO50/ZM=; b=yfbRf0W1gyJR95Qmx5JJnQt+OM qgn9KiTJ9IS7tutZwW1GGxRxwHplLcVxyRYDNbb3peS6gF0zDLImUUnS8R88sWuODh5tNduu+1mXn UWOSkUliATX9IwaS/0fudB5FO; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:49456 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1g9JKP-000T1C-Cu; Sun, 07 Oct 2018 19:23:17 -0500 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFC 3/8] Add output styles to gdb References: <20180906211303.11029-1-tom@tromey.com> <20180906211303.11029-4-tom@tromey.com> <87va6eevyo.fsf@tromey.com> Date: Mon, 08 Oct 2018 00:23:00 -0000 In-Reply-To: (Simon Marchi's message of "Sun, 7 Oct 2018 17:58:24 -0400") Message-ID: <87pnwlcmmj.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-10/txt/msg00165.txt.bz2 >> These questions about the overall approach and the API are the main >> things to resolve up front, since they have the highest cost to change. Simon> Indeed, but at least it's not external API, so we have the option to change. The main thing I am concerned about is that if we pick the approach I've implemented, then changing our minds to a format-based approach will be harder. I think that's the case because the user-facing "set"s would be hard to migrate to a format-based approach. And, FWIW, I think the format-based approach isn't super hard to implement. The main problems there are design problems: whether to remap the names of tables and fields; how to handle the trouble cases I found in my initial investigation; and of course whether there are more difficult cases lurking. Overall I think I'm in favor of the approach I've posted, but I think it's a good to examine this idea critically. Tom