From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 94807 invoked by alias); 16 Sep 2018 15:35:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 94478 invoked by uid 89); 16 Sep 2018 15:35:45 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:625, solely, ideally X-HELO: gateway23.websitewelcome.com Received: from gateway23.websitewelcome.com (HELO gateway23.websitewelcome.com) (192.185.50.164) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 16 Sep 2018 15:35:44 +0000 Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway23.websitewelcome.com (Postfix) with ESMTP id DF8C2733 for ; Sun, 16 Sep 2018 10:35:41 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 1Z5DgZmzkbXuJ1Z5Hgs3PL; Sun, 16 Sep 2018 10:35:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=PaLyMqfX6dr/5DfpTq81L9ZGVhd9qe5HdKqZ6rORiAA=; b=qrGtjdY5NM5VE7AA1hsVo81Cwa ZZKGNBXgVDa8DdCCmACG9TGzDpB8jykA43TOtuWw58yAkrFoFetGoMaMzH365SpmXvJTXG/rut6Za Jza9WJB+YWmGAO2kty7slCoQL; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:46518 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1g1Z5D-000C4c-EH; Sun, 16 Sep 2018 10:35:35 -0500 From: Tom Tromey To: Tom Tromey Cc: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH 3/4] Change thread_to_thread_object to return a new reference References: <20180913053007.11780-1-tom@tromey.com> <20180913053007.11780-4-tom@tromey.com> <38dedd0d-1f03-eb7d-84a6-15cdc29e8ea2@simark.ca> <875zz5pmg8.fsf@tromey.com> Date: Sun, 16 Sep 2018 15:35:00 -0000 In-Reply-To: <875zz5pmg8.fsf@tromey.com> (Tom Tromey's message of "Sun, 16 Sep 2018 08:05:11 -0600") Message-ID: <87pnxdo3p5.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-09/txt/msg00546.txt.bz2 >>>>> "Tom" == Tom Tromey writes: Tom> I think it is best to have a single style - returning NULL should also Tom> set the Python exception. Maybe the gdbpy_ref (1-argument) constructor and release methods could assert that the Python exception is set if the underlying pointer is NULL. That would not get full checking but maybe it would catch some problems. And maybe we should simply use gdbpy_ref in many more places in the Python layer -- ideally, reserve raw pointers solely for parameters which are borrowed references. Tom