public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Richard Bunt <richard.bunt@arm.com>
Cc: Tom Tromey <tom@tromey.com>,  gdb-patches@sourceware.org,  nd@arm.com
Subject: Re: [PATCH v2] Logical short circuiting with argument lists
Date: Wed, 12 Sep 2018 11:38:00 -0000	[thread overview]
Message-ID: <87pnxjj688.fsf@tromey.com> (raw)
In-Reply-To: <2fd31db3-e0f7-262b-6b30-bd7a78cbabbf@arm.com> (Richard Bunt's	message of "Wed, 12 Sep 2018 09:15:07 +0100")

>>>>> "Rich" == Rich Bunt <richard.bunt@arm.com> writes:

>> Though, another option is to do this in a fortran-specific way.

Rich> Are you able to provide some more details on this approach please?

Sure.  Each language provides its own evaluation function.  These
functions can change the interpretation -- or even, in collusion with
the language's expression parser the layout in memory -- of a given
opcode.  Most languages just defer to the generic evaluator.

E.g., look at rust-lang.c:rust_evaluate_subexp.  It changes UNOP_IND to
handle Rust trait objects, among other things.

Fortran doesn't have one of these as f_language_defn refers to
exp_descriptor_standard.

The whole expression data structure and approach is bad and should be
rewritten.

Anyway, doing this may be overkill, unless we think of some downside to
your approach.

Rich> However, if I had used a space between the array symbol name
Rich> and the parenthesizes this would have been a problem. This is
Rich> useful to know.

Yeah.  A bit subtle for my taste, I feel certain I'll break this rule by
accident.

Tom

  reply	other threads:[~2018-09-12 11:38 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-16 16:03 Richard Bunt
2018-09-04  8:26 ` [PING][PATCH " Richard Bunt
2018-09-07 22:23 ` [PATCH " Tom Tromey
2018-09-07 22:29   ` Simon Marchi
2018-09-07 22:34     ` Simon Marchi
2018-09-07 22:36     ` Tom Tromey
2018-09-08 21:25   ` Simon Marchi
2018-09-12  8:16   ` Richard Bunt
2018-09-12 11:38     ` Tom Tromey [this message]
2018-09-12 13:04       ` Pedro Alves
2018-09-15 21:03         ` Tom Tromey
2018-09-17 18:04       ` Richard Bunt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pnxjj688.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=nd@arm.com \
    --cc=richard.bunt@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).