From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [ANNOUNCEMENT] GDB 8.1 release branch created!
Date: Tue, 16 Jan 2018 19:02:00 -0000 [thread overview]
Message-ID: <87po69zkxe.fsf@redhat.com> (raw)
In-Reply-To: <83h8rlyakm.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 16 Jan 2018 19:31:37 +0200")
On Tuesday, January 16 2018, Eli Zaretskii wrote:
> I've built this pre-release with mingw.org's MinGW, and found a few
> problems.
[...]
> The other problems I saw are compilation warnings, see below. Some of
> them sound like GCC doesn't understand our TRY/CATCH blocks, but others
> seem like real problems, at least from the POV of a naïve reader such
> as myself. I wonder how come others don't see these warnings, and why
> weren't they fixed during development, when we use -Werror. Here are
> the warnings I saw:
>
[...]
> g++ -x c++ -O2 -gdwarf-4 -g3 -I. -I. -I./common -I./config -DLOCALEDIR="\"d:/usr/share/locale\"" -DHAVE_CONFIG_H -I./../include/opcode -I./../opcodes/.. -I./../readline/.. -I../bfd -I./../bfd -I./../include -I../libdecnumber -I./../libdecnumber -I./gnulib/import -Ibuild-gnulib/import -DTUI=1 -Id:/usr/include -Id:/usr/include/guile/2.0 -Id:/usr/include -Id:/usr/Python26/include -Id:/usr/Python26/include -Wall -Wpointer-arith -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts -Wempty-body -Wunused-but-set-parameter -Wunused-but-set-variable -Wno-sign-compare -Wno-narrowing -Wno-error=maybe-uninitialized -Wno-format -c -o infrun.o -MT infrun.o -MMD -MP -MF ./.deps/infrun.Tpo infrun.c
> In file included from infrun.c:26:0:
> inferior.h: In function 'void handle_vfork_child_exec_or_exit(int)':
> inferior.h:537:39: warning: '*((void*)(& maybe_restore_inferior)+20).scoped_restore_current_inferior::m_saved_inf' may be used uninitialized in this function [-Wmaybe-uninitialized]
> { set_current_inferior (m_saved_inf); }
> ^
> infrun.c:927:6: note: '*((void*)(& maybe_restore_inferior)+20).scoped_restore_current_inferior::m_saved_inf' was declared here
> maybe_restore_inferior;
> ^~~~~~~~~~~~~~~~~~~~~~
> In file included from inferior.h:48:0,
> from infrun.c:26:
> progspace.h:285:47: warning: '*((void*)(& maybe_restore_inferior)+16).scoped_restore_current_program_space::m_saved_pspace' may be used uninitialized in this function [-Wmaybe-uninitialized]
> { set_current_program_space (m_saved_pspace); }
> ^
> infrun.c:927:6: note: '*((void*)(& maybe_restore_inferior)+16).scoped_restore_current_program_space::m_saved_pspace' was declared here
> maybe_restore_inferior;
> ^~~~~~~~~~~~~~~~~~~~~~
>
> g++ -x c++ -O2 -gdwarf-4 -g3 -I. -I. -I./common -I./config -DLOCALEDIR="\"d:/usr/share/locale\"" -DHAVE_CONFIG_H -I./../include/opcode -I./../opcodes/.. -I./../readline/.. -I../bfd -I./../bfd -I./../include -I../libdecnumber -I./../libdecnumber -I./gnulib/import -Ibuild-gnulib/import -DTUI=1 -Id:/usr/include -Id:/usr/include/guile/2.0 -Id:/usr/include -Id:/usr/Python26/include -Id:/usr/Python26/include -Wall -Wpointer-arith -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts -Wempty-body -Wunused-but-set-parameter -Wunused-but-set-variable -Wno-sign-compare -Wno-narrowing -Wno-error=maybe-uninitialized -Wno-format -c -o typeprint.o -MT typeprint.o -MMD -MP -MF ./.deps/
> typeprint.Tpo typeprint.c
> typeprint.c: In function 'void whatis_exp(const char*, int)':
> typeprint.c:515:60: warning: 'val' may be used uninitialized in this function [-Wmaybe-uninitialized]
> real_type = value_rtti_type (val, &full, &top, &using_enc);
> ^
>
> g++ -x c++ -O2 -gdwarf-4 -g3 -I. -I. -I./common -I./config -DLOCALEDIR="\"d:/usr/share/locale\"" -DHAVE_CONFIG_H -I./../include/opcode -I./../opcodes/.. -I./../readline/.. -I../bfd -I./../bfd -I./../include -I../libdecnumber -I./../libdecnumber -I./gnulib/import -Ibuild-gnulib/import -DTUI=1 -Id:/usr/include -Id:/usr/include/guile/2.0 -Id:/usr/include -Id:/usr/Python26/include -Id:/usr/Python26/include -Wall -Wpointer-arith -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts -Wempty-body -Wunused-but-set-parameter -Wunused-but-set-variable -Wno-sign-compare -Wno-narrowing -Wno-error=maybe-uninitialized -Wno-format -c -o compile/compile.o -MT compile/compile.o -MMD -MP -MF compile/.deps/compile.Tpo compile/compile.c
> compile/compile.c: In function 'void eval_compile_command(command_line*, const char*, compile_i_scope_types, void*)':
> compile/compile.c:549:20: warning: 'triplet_rx' may be used uninitialized in this function [-Wmaybe-uninitialized]
> argc, argv);
> ^
> compile/compile.c:466:9: note: 'triplet_rx' was declared here
> char *triplet_rx;
> ^~~~~~~~~~
FWIW, I've seen these warnings when preparing a Fedora GDB release.
I'll take a look at them.
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/
next prev parent reply other threads:[~2018-01-16 19:02 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <announce.20180105041805.3FC35808E9@joel.gnat.com>
2018-01-16 17:31 ` Eli Zaretskii
2018-01-16 19:02 ` Sergio Durigan Junior [this message]
2018-01-16 19:46 ` [PATCH] Fix warning on gdb/compile/compile.c (C++-ify "triplet_rx") Sergio Durigan Junior
2018-01-17 15:33 ` Eli Zaretskii
2018-01-17 17:17 ` Simon Marchi
2018-01-17 23:07 ` Sergio Durigan Junior
2018-01-17 23:42 ` Simon Marchi
2018-01-17 23:48 ` Sergio Durigan Junior
2018-01-16 20:32 ` [PATCH] Fix unitialized warning on gdb/typeprint.c:whatis_exp Sergio Durigan Junior
2018-01-17 15:34 ` Eli Zaretskii
2018-01-17 16:48 ` Pedro Alves
2018-01-17 18:03 ` Sergio Durigan Junior
2018-01-20 1:03 ` [PATCH] Fix segfault when using 'set print object on' + whatis <struct> Sergio Durigan Junior
2018-01-22 17:42 ` [PATCH v2] Fix segfault when using 'set print object on' + whatis <struct> (Re: [PATCH] Fix segfault when using 'set print object on' + whatis <struct>) Pedro Alves
2018-01-22 18:04 ` Sergio Durigan Junior
2018-01-22 19:53 ` Pedro Alves
2018-01-22 20:11 ` Sergio Durigan Junior
2018-01-16 20:36 ` [ANNOUNCEMENT] GDB 8.1 release branch created! Sergio Durigan Junior
2018-01-17 3:36 ` Eli Zaretskii
2018-01-17 16:46 ` Sergio Durigan Junior
2018-01-17 11:04 ` Pedro Alves
2018-01-17 16:38 ` Sergio Durigan Junior
2018-01-17 16:46 ` Eli Zaretskii
2018-01-17 16:50 ` Pedro Alves
2018-01-17 18:21 ` Eli Zaretskii
2018-01-18 15:53 ` Eli Zaretskii
2018-01-25 16:58 ` Eli Zaretskii
2018-01-26 14:18 ` Eli Zaretskii
2018-01-26 15:37 ` Simon Marchi
2018-01-26 18:53 ` Eli Zaretskii
2018-01-27 16:42 ` Eli Zaretskii
2018-02-01 15:12 ` Yao Qi
2018-02-01 16:27 ` Eli Zaretskii
2018-02-01 16:51 ` Yao Qi
2018-02-01 17:33 ` Eli Zaretskii
2018-02-01 21:32 ` Yao Qi
2018-02-02 15:23 ` Eli Zaretskii
2018-02-02 15:53 ` Joel Brobecker
2018-02-02 16:27 ` Simon Marchi
2018-02-02 17:42 ` Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87po69zkxe.fsf@redhat.com \
--to=sergiodj@redhat.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).