From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Simon Marchi <simon.marchi@ericsson.com>
Cc: GDB Patches <gdb-patches@sourceware.org>,
Tom Tromey <tom@tromey.com>, Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH v3 1/2] Reorganize code to handle TYPE_CODE_{STRUCT,UNION} on 'c_type_print_base'
Date: Mon, 11 Dec 2017 23:05:00 -0000 [thread overview]
Message-ID: <87po7kc1cu.fsf@redhat.com> (raw)
In-Reply-To: <9f8ee5f9-6f73-107f-c9d7-d6c31b5be98c@ericsson.com> (Simon Marchi's message of "Mon, 11 Dec 2017 15:54:55 -0500")
On Monday, December 11 2017, Simon Marchi wrote:
> Hi Sergio,
>
> LGTM, with some nits.
Thanks for the review.
> On 2017-12-11 02:57 PM, Sergio Durigan Junior wrote:
>> diff --git a/gdb/c-typeprint.c b/gdb/c-typeprint.c
>> index f3c3e7d706..46c814fae8 100644
>> --- a/gdb/c-typeprint.c
>> +++ b/gdb/c-typeprint.c
>> @@ -875,6 +875,458 @@ output_access_specifier (struct ui_file *stream,
>> return last_access;
>> }
>>
>> +/* Return true is an access label (i.e., "public:", "private:",
>> + "protected:") needs to be printed for TYPE. */
>> +
>> +static bool
>> +need_access_label_p (struct type *type)
>> +{
>> + bool need_access_label = false;
>> + int i, j;
>> + int len, len2;
>> +
>> + if (TYPE_DECLARED_CLASS (type))
>> + {
>> + QUIT;
>> + len = TYPE_NFIELDS (type);
>> + for (i = TYPE_N_BASECLASSES (type); i < len; i++)
>> + if (!TYPE_FIELD_PRIVATE (type, i))
>> + {
>> + need_access_label = true;
>> + break;
>> + }
>> + QUIT;
>> + if (!need_access_label)
>> + {
>> + len2 = TYPE_NFN_FIELDS (type);
>> + for (j = 0; j < len2; j++)
>> + {
>> + len = TYPE_FN_FIELDLIST_LENGTH (type, j);
>> + for (i = 0; i < len; i++)
>> + if (!TYPE_FN_FIELD_PRIVATE (TYPE_FN_FIELDLIST1 (type,
>> + j), i))
>> + {
>> + need_access_label = true;
>> + break;
>> + }
>> + if (need_access_label)
>> + break;
>> + }
>> + }
>> + QUIT;
>> + if (!need_access_label)
>> + {
>> + for (i = 0; i < TYPE_TYPEDEF_FIELD_COUNT (type); ++i)
>> + {
>> + if (!TYPE_TYPEDEF_FIELD_PRIVATE (type, i))
>> + {
>> + need_access_label = true;
>> + break;
>> + }
>> + }
>> + }
>> + }
>> + else
>> + {
>> + QUIT;
>> + len = TYPE_NFIELDS (type);
>> + for (i = TYPE_N_BASECLASSES (type); i < len; i++)
>> + if (TYPE_FIELD_PRIVATE (type, i)
>> + || TYPE_FIELD_PROTECTED (type, i))
>> + {
>> + need_access_label = true;
>> + break;
>> + }
>> + QUIT;
>> + if (!need_access_label)
>> + {
>> + len2 = TYPE_NFN_FIELDS (type);
>> + for (j = 0; j < len2; j++)
>> + {
>> + QUIT;
>> + len = TYPE_FN_FIELDLIST_LENGTH (type, j);
>> + for (i = 0; i < len; i++)
>> + if (TYPE_FN_FIELD_PROTECTED (TYPE_FN_FIELDLIST1 (type,
>> + j), i)
>> + || TYPE_FN_FIELD_PRIVATE (TYPE_FN_FIELDLIST1 (type,
>> + j),
>> + i))
>> + {
>> + need_access_label = true;
>> + break;
>> + }
>> + if (need_access_label)
>> + break;
>> + }
>> + }
>> + QUIT;
>> + if (!need_access_label)
>> + {
>> + for (i = 0; i < TYPE_TYPEDEF_FIELD_COUNT (type); ++i)
>> + {
>> + if (TYPE_TYPEDEF_FIELD_PROTECTED (type, i)
>> + || TYPE_TYPEDEF_FIELD_PRIVATE (type, i))
>> + {
>> + need_access_label = true;
>> + break;
>> + }
>> + }
>> + }
>> + }
>> +
>> + return need_access_label;
>
> It seems to me that you could return immediately when you detect that a label is
> needed. It would allow removing a bunch of if (!need_access_label).
Done.
>> @@ -898,10 +1350,8 @@ c_type_print_base (struct type *type, struct ui_file *stream,
>> int show, int level, const struct type_print_options *flags)
>> {
>> int i;
>> - int len, real_len;
>> - enum access_specifier section_type;
>> - int need_access_label = 0;
>> - int j, len2;
>> + int len;
>> + int j;
>
> j is unused.
Removed.
Thanks,
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/
next prev parent reply other threads:[~2017-12-11 23:05 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-21 16:07 [PATCH] Implement pahole-like 'ptype /o' option Sergio Durigan Junior
2017-11-21 16:16 ` Sergio Durigan Junior
2017-11-21 16:50 ` Eli Zaretskii
2017-11-21 17:00 ` Sergio Durigan Junior
2017-11-21 19:14 ` Eli Zaretskii
2017-11-26 19:27 ` Tom Tromey
2017-11-27 19:54 ` Sergio Durigan Junior
2017-11-27 22:20 ` Tom Tromey
2017-11-28 0:39 ` Sergio Durigan Junior
2017-11-28 21:21 ` [PATCH v2] " Sergio Durigan Junior
2017-11-29 3:28 ` Eli Zaretskii
2017-12-04 15:03 ` Sergio Durigan Junior
2017-12-04 15:41 ` Eli Zaretskii
2017-12-04 16:47 ` Sergio Durigan Junior
2017-12-08 21:32 ` Sergio Durigan Junior
2017-12-11 15:43 ` Simon Marchi
2017-12-11 18:59 ` Sergio Durigan Junior
2017-12-11 20:45 ` Simon Marchi
2017-12-11 21:07 ` Sergio Durigan Junior
2017-12-11 22:42 ` Pedro Alves
2017-12-11 22:50 ` Sergio Durigan Junior
2017-12-11 23:46 ` Pedro Alves
2017-12-12 0:25 ` Sergio Durigan Junior
2017-12-12 0:52 ` Pedro Alves
2017-12-12 1:25 ` Simon Marchi
2017-12-12 15:50 ` John Baldwin
2017-12-12 17:04 ` Sergio Durigan Junior
2017-12-11 19:58 ` [PATCH v3 0/2] Implement pahole-like 'ptype /o' option (and do some code reorg) Sergio Durigan Junior
2017-12-11 19:58 ` [PATCH v3 1/2] Reorganize code to handle TYPE_CODE_{STRUCT,UNION} on 'c_type_print_base' Sergio Durigan Junior
2017-12-11 20:55 ` Simon Marchi
2017-12-11 23:05 ` Sergio Durigan Junior [this message]
2017-12-11 19:58 ` [PATCH v3 2/2] Implement pahole-like 'ptype /o' option Sergio Durigan Junior
2017-12-11 21:50 ` Simon Marchi
2017-12-11 23:24 ` Sergio Durigan Junior
2017-12-12 1:32 ` Simon Marchi
2017-12-12 6:19 ` Sergio Durigan Junior
2017-12-12 18:14 ` Pedro Alves
2017-12-12 18:40 ` Sergio Durigan Junior
2017-12-12 20:12 ` Pedro Alves
2017-12-11 23:43 ` [PATCH v4 0/2] Implement pahole-like 'ptype /o' option (and do some code reorg) Sergio Durigan Junior
2017-12-11 23:44 ` [PATCH v4 2/2] Implement pahole-like 'ptype /o' option Sergio Durigan Junior
2017-12-12 0:27 ` Sergio Durigan Junior
2017-12-12 0:29 ` Sergio Durigan Junior
2017-12-12 1:59 ` Simon Marchi
2017-12-12 3:39 ` Eli Zaretskii
2017-12-11 23:44 ` [PATCH v4 1/2] Reorganize code to handle TYPE_CODE_{STRUCT,UNION} on 'c_type_print_base' Sergio Durigan Junior
2017-12-13 3:17 ` [PATCH v5 0/2] Implement pahole-like 'ptype /o' option (and do some code reorg) Sergio Durigan Junior
2017-12-13 3:17 ` [PATCH v5 1/2] Reorganize code to handle TYPE_CODE_{STRUCT,UNION} on 'c_type_print_base' Sergio Durigan Junior
2017-12-13 3:17 ` [PATCH v5 2/2] Implement pahole-like 'ptype /o' option Sergio Durigan Junior
2017-12-13 4:50 ` Simon Marchi
2017-12-13 16:42 ` Sergio Durigan Junior
2017-12-13 16:17 ` Eli Zaretskii
2017-12-13 17:14 ` Sergio Durigan Junior
2017-12-13 16:19 ` Pedro Alves
2017-12-13 17:13 ` Sergio Durigan Junior
2017-12-13 20:36 ` Sergio Durigan Junior
2017-12-13 21:22 ` Pedro Alves
2017-12-13 21:30 ` Pedro Alves
2017-12-13 21:34 ` Sergio Durigan Junior
2017-12-13 16:20 ` Pedro Alves
2017-12-13 17:41 ` Sergio Durigan Junior
2017-12-14 2:48 ` [PATCH v6 0/2] Implement pahole-like 'ptype /o' option (and do some code reorg) Sergio Durigan Junior
2017-12-14 2:48 ` [PATCH v6 2/2] Implement pahole-like 'ptype /o' option Sergio Durigan Junior
2017-12-14 14:19 ` Pedro Alves
2017-12-14 20:31 ` Sergio Durigan Junior
2017-12-14 14:50 ` Pedro Alves
2017-12-14 20:29 ` Sergio Durigan Junior
2017-12-14 16:30 ` Eli Zaretskii
2017-12-14 2:48 ` [PATCH v6 1/2] Reorganize code to handle TYPE_CODE_{STRUCT,UNION} on 'c_type_print_base' Sergio Durigan Junior
2017-12-15 1:12 ` [PATCH v7 0/2] Implement pahole-like 'ptype /o' option (and do some code reorg) Sergio Durigan Junior
2017-12-15 1:12 ` [PATCH v7 1/2] Reorganize code to handle TYPE_CODE_{STRUCT,UNION} on 'c_type_print_base' Sergio Durigan Junior
2017-12-15 1:13 ` [PATCH v7 2/2] Implement pahole-like 'ptype /o' option Sergio Durigan Junior
2017-12-15 17:24 ` Pedro Alves
2017-12-15 20:04 ` Sergio Durigan Junior
2017-12-15 20:11 ` [PATCH v7 0/2] Implement pahole-like 'ptype /o' option (and do some code reorg) Sergio Durigan Junior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87po7kc1cu.fsf@redhat.com \
--to=sergiodj@redhat.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).