Re: [PATCH 2/2] Catching errors on probes-based dynamic linker interface

[Sergio Durigan Junior <sergiodj@redhat.com>]

On Wednesday, September 02 2015, I wrote:

> On Tuesday, September 01 2015, I wrote:
>
>>> I am ok with doing this:
>>>
>>>   TRY
>>>     {
>>>       probe_argc = get_probe_argument_count (pa->probe, frame);
>>>     }
>>>   CATCH (ex, RETURN_MASK_ERROR)
>>>     {
>>>       exception_print (gdb_stderr, ex);
>>>       probe_argc = 0;
>>>     }
>>>   END_CATCH
>>>
>>> If you put a big fat comment above the following block, e.g.:
>>>
>>>   /* Note that failure of get_probe_argument_count will
>>>      set probe_argc == 0.  This must result in returning
>>>      action = PROBES_INTERFACE_FAILED.  */
>>>   if (probe_argc == 2)
>>>     action = FULL_RELOAD;
>>>   else if (probe_argc < 2)
>>>     action = PROBES_INTERFACE_FAILED;
>>
>> Great, that works for me as well.  I will update the patch here to
>> address this.
>
> I took the liberty to modify and expand the comment; I hope you still
> find it OK.  Here's what I pushed.

Pushed.

  https://sourceware.org/ml/gdb-cvs/2015-09/msg00002.html

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/