From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18999 invoked by alias); 25 Oct 2013 16:37:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18969 invoked by uid 89); 25 Oct 2013 16:37:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 25 Oct 2013 16:37:21 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9PGbJkS032127 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 25 Oct 2013 12:37:19 -0400 Received: from barimba (ovpn-113-54.phx2.redhat.com [10.3.113.54]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r9PGbIeL013665 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 25 Oct 2013 12:37:19 -0400 From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 07/17] fix up gdb.trace References: <1382129374-18344-1-git-send-email-tromey@redhat.com> <1382129374-18344-8-git-send-email-tromey@redhat.com> <526A9AB8.1090500@redhat.com> Date: Fri, 25 Oct 2013 16:37:00 -0000 In-Reply-To: <526A9AB8.1090500@redhat.com> (Pedro Alves's message of "Fri, 25 Oct 2013 17:22:16 +0100") Message-ID: <87ppqt488x.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-10/txt/msg00808.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> On 10/18/2013 09:49 PM, Tom Tromey wrote: >> +if {![is_remote host] && ![is_remote target]} { >> + set tfile_basic [standard_output_file tfile-basic.tf] >> + set tfile_dir [file dirname $tfile_basic]/ >> + set purely_local 1 >> +} else { >> + set purely_local 0 >> + set tfile_basic tfile-basic.tf >> + set tfile_dir "" >> +} >> + Pedro> Minor, minor nit. Can you define the variables in the same Pedro> order in both branches? My eyes crossed a little going back Pedro> and forth comparing the values of both branches, for the Pedro> branches not having the same pattern. Sorry for the trouble. It's no trouble. I made the change locally. Tom