From: Tom Tromey <tromey@adacore.com>
To: Andrew Burgess <aburgess@redhat.com>
Cc: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Use generic_printstr from ada_language::printstr
Date: Thu, 12 Dec 2024 07:42:49 -0700 [thread overview]
Message-ID: <87r06dgdxy.fsf@tromey.com> (raw)
In-Reply-To: <878qslgmvu.fsf@redhat.com> (Andrew Burgess's message of "Thu, 12 Dec 2024 11:29:41 +0000")
>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:
Andrew> I guess this is fine. Maybe the bug which I haven't bothered to track
Andrew> down explains the problems, but I'd expect ada_printstr to be formatting
Andrew> things differently to generic_printstr, so surely there will be weird
Andrew> differences now depending on the string type?
Yeah, there could be minor differences here if the string has some
invalid UTF-8 sequences. But that's less important, IMO, than getting
UTF-8 output correct.
Andrew> With the minor issues fixed:
Andrew> Approved-By: Andrew Burgess <aburgess@redhat.com>
Thanks, I fixed these up.
Also:
Andrew> I went through and removed all the 'then' at one point.
... I found more, I'll send a patch momentarily.
Tom
next prev parent reply other threads:[~2024-12-12 14:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-04 18:32 Tom Tromey
2024-12-12 11:29 ` Andrew Burgess
2024-12-12 14:42 ` Tom Tromey [this message]
2024-12-12 14:58 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r06dgdxy.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).