From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id 88FEA398A7CF for ; Wed, 5 Jun 2024 16:11:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 88FEA398A7CF Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 88FEA398A7CF Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1717603892; cv=none; b=lFJM8co1yq95wWlJNAfH8IyxMk/gGMpLaveHCyMZ+Fs7sHXDVaKpGmkbFpL5p9bN/1BGXV16AyImzPssyqCUOIKF+DbmOSgMzj7slbM6VuXhiCcoEtGz63X/bblka82Plz5vWNUlW1U4X6jvt8gwjOZIJ8r/sa4UIR5aHkQqgiM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1717603892; c=relaxed/simple; bh=0mf29cpBlbh5Uzs+IBdwOZVqxXua1+oFGpEZDw9qJu8=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=KHLQoDvfExmHpMPlhZ98vzBCAoaFIKncm+w0Kg12kQPrvg122vETcdtUiqq0C85Pdbi414YOk51X4F7QDWlPudAECI5jrB2m7GQGlF1a+50Ha75z7iu5n5J9P4UqUuEoOWOZgu5rKAmCmW9N0ByDEcgRUUupPu9sKpk4t71obYY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5009a.ext.cloudfilter.net ([10.0.29.176]) by cmsmtp with ESMTPS id EogxsXhZDSqshEtEYsqnyP; Wed, 05 Jun 2024 16:11:30 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id EtEXszsQrCzGwEtEXs6a08; Wed, 05 Jun 2024 16:11:30 +0000 X-Authority-Analysis: v=2.4 cv=euXZzJpX c=1 sm=1 tr=0 ts=66608e32 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=T1WGqf2p2xoA:10 a=Qbun_eYptAEA:10 a=20KFwNOVAAAA:8 a=A3L8f7lELrbhXDnhEmgA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=EKHS2qwbRd4CptFFviHkrzveoGNab4Tty7u0lFd8Jn4=; b=QU0D0O6kvztGvNFUWHmyeSb3k9 acULVfVpvONgeSf4BdYJb2jGDSTNhuf4eFkWOOjRUzsQ8VDQS3vVO3GPpvKgtxBy2Wr6GvJc2Kkgc HJqCh3W6wnl/heXbuPrLxPPxg; Received: from 75-166-134-4.hlrn.qwest.net ([75.166.134.4]:42668 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1sEtEX-002QWI-0b; Wed, 05 Jun 2024 10:11:29 -0600 From: Tom Tromey To: Guinevere Larsen Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/3] gdb: Start supporting AVX instruction In-Reply-To: <20240521202800.2865871-2-blarsen@redhat.com> (Guinevere Larsen's message of "Tue, 21 May 2024 17:27:58 -0300") References: <20240521202800.2865871-1-blarsen@redhat.com> <20240521202800.2865871-2-blarsen@redhat.com> X-Attribution: Tom Date: Wed, 05 Jun 2024 10:11:28 -0600 Message-ID: <87r0dbnzdb.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.134.4 X-Source-L: No X-Exim-ID: 1sEtEX-002QWI-0b X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-134-4.hlrn.qwest.net (murgatroyd) [75.166.134.4]:42668 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfLPZafmI/k0lB7UF3LPqgLZK4XGx1/mzQJQopSmqLdOJaKbUOWIzfUSdcYmlyhAGfVo7nqu6X7biToSNCMMF5eGhq2nSK8hBRMc0Z0Cblw/vSZdsThxG ch2mwC03Wp5KTqgCs5XOcA+GirR5Rm43iQ5vzD7Ui130i7Jwc0B7IgsJV/3BJGu2xG4QfPoQDWnS6vfTuEzWBOtewqzxOjtXJaQ= X-Spam-Status: No, score=-3014.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Guinevere" == Guinevere Larsen writes: Guinevere> + /* These are used by VEX and XOP prefixes. */ Guinevere> + uint8_t map_select; Guinevere> + uint8_t vvvv; Guinevere> + uint8_t pp; Guinevere> + uint8_t l; Are these the names used by the ISA? Since if not they are pretty ugly. Guinevere> +static bool Guinevere> +i386_record_vex (struct i386_record_s *ir, uint8_t rex_w, uint8_t rex_r, Guinevere> + int opcode, struct gdbarch *gdbarch) Guinevere> +{ Guinevere> + switch (opcode) Guinevere> + { Guinevere> + default: Guinevere> + gdb_printf (gdb_stderr, Guinevere> + _("Process record does not support VEX instruction 0x%02x " Guinevere> + "at address %s.\n"), Guinevere> + (unsigned int) (opcode), Guinevere> + paddress (gdbarch, ir->orig_addr)); Guinevere> + return -1; This should use true or false, not -1, because the function returns bool. I wouldn't be surprised to get some kind of dead code warning here, since the switch only has a single branch. Tom