* [PATCH] Remove fflush call from tui_refresh_cmd_win
@ 2024-04-26 16:33 Tom Tromey
2024-05-14 19:08 ` Tom Tromey
0 siblings, 1 reply; 2+ messages in thread
From: Tom Tromey @ 2024-04-26 16:33 UTC (permalink / raw)
To: gdb-patches; +Cc: Tom Tromey
tui_refresh_cmd_win calls fflush, but there's a comment explaining
that the reason for the call is unknown. This patch removes the call.
I don't think it can be useful, since gdb doesn't generally use stdout
in this way -- only through ui_file.
---
gdb/tui/tui-command.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/gdb/tui/tui-command.c b/gdb/tui/tui-command.c
index 59e595525b0..b0ae8f39e0e 100644
--- a/gdb/tui/tui-command.c
+++ b/gdb/tui/tui-command.c
@@ -64,9 +64,4 @@ tui_refresh_cmd_win (void)
WINDOW *w = TUI_CMD_WIN->handle.get ();
tui_wrefresh (w);
-
- /* FIXME: It's not clear why this is here.
- It was present in the original tui_puts code and is kept in order to
- not introduce some subtle breakage. */
- fflush (stdout);
}
--
2.44.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Remove fflush call from tui_refresh_cmd_win
2024-04-26 16:33 [PATCH] Remove fflush call from tui_refresh_cmd_win Tom Tromey
@ 2024-05-14 19:08 ` Tom Tromey
0 siblings, 0 replies; 2+ messages in thread
From: Tom Tromey @ 2024-05-14 19:08 UTC (permalink / raw)
To: Tom Tromey; +Cc: gdb-patches
>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:
Tom> tui_refresh_cmd_win calls fflush, but there's a comment explaining
Tom> that the reason for the call is unknown. This patch removes the call.
Tom> I don't think it can be useful, since gdb doesn't generally use stdout
Tom> in this way -- only through ui_file.
I'm checking this in.
Tom
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-05-14 19:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-26 16:33 [PATCH] Remove fflush call from tui_refresh_cmd_win Tom Tromey
2024-05-14 19:08 ` Tom Tromey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).