From: Tom Tromey <tromey@adacore.com>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2 3/3] Add symbol, line, and location to DAP disassemble result
Date: Fri, 03 May 2024 09:46:57 -0600 [thread overview]
Message-ID: <87r0eidhji.fsf@tromey.com> (raw)
In-Reply-To: <20240430131702.218184-4-tromey@adacore.com> (Tom Tromey's message of "Tue, 30 Apr 2024 07:15:33 -0600")
>>>>> "Tom" == Tom Tromey <tromey@adacore.com> writes:
Tom> The DAP spec allows a number of attributes on the resulting
Tom> instructions that gdb currently does not emit. A user requested some
Tom> of these, so this patch adds the 'symbol', 'line', and 'location'
Tom> attributes. While the spec lets the implementation omit 'location' in
Tom> some cases, it was simpler in the code to just always emit it, as then
Tom> no extra tracking was needed.
Tom> + if sal.line != 0:
Tom> + result["line"] = str(sal.line)
A co-worker noticed that this is emitting a string instead of a number,
contrary to the spec. I've fixed this locally.
Tom
next prev parent reply other threads:[~2024-05-03 15:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 13:15 [PATCH v2 0/3] Add more info to DAP disassemble response Tom Tromey
2024-04-30 13:15 ` [PATCH v2 1/3] Simplify DAP make_source callers Tom Tromey
2024-04-30 13:15 ` [PATCH v2 2/3] Implement tp_richcompare for gdb.Block Tom Tromey
2024-04-30 13:15 ` [PATCH v2 3/3] Add symbol, line, and location to DAP disassemble result Tom Tromey
2024-05-03 15:46 ` Tom Tromey [this message]
2024-05-10 18:35 ` [PATCH v2 0/3] Add more info to DAP disassemble response Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0eidhji.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).