From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd2e.google.com (mail-io1-xd2e.google.com [IPv6:2607:f8b0:4864:20::d2e]) by sourceware.org (Postfix) with ESMTPS id 9F8D43849ADD for ; Fri, 3 May 2024 15:46:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9F8D43849ADD Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9F8D43849ADD Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d2e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714751221; cv=none; b=nu0ceCG2H7RWj/eElljF13R/A6GH4qLaXI3lXoJzGjoA1JJt/iSECZNqFpH7ZsRYgFCdo/sxzqWeumlWmRBIw0wAHmarLORc0Jwy5FejNRQLnU/Hu4+KdkhFv9cc3qyHIdanItThrq61y7ZvVLNipKapQTJ5VSSXG2rQFF1onZA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714751221; c=relaxed/simple; bh=LpEirAx0OWyoW1y+vOzwf4j6LWAQkLvFVJCz2jX8KVM=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=VzdQJhgjb+NGFpCmnceSgqdHCPCKxL8kz7uW54KcRyI9mfvv69xSUYPeY+AEZ60dGq4+7E4R/X5LhMmCbUgirSrr5nDyP6Dr8PUYW95NpYrKuMbhoLU8ARNXms1AErS+y3pBmpZJbnBICh3TNIICswoRlGPVMHw/e5hdo0l0N9A= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-io1-xd2e.google.com with SMTP id ca18e2360f4ac-7deb424da41so328118139f.1 for ; Fri, 03 May 2024 08:46:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1714751219; x=1715356019; darn=sourceware.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=+hxGtO3uIWBoJidluPklvlR8A24G9Z4q60k2CmruTiw=; b=F4fgpsLiUK2ReJ1MQNn740H+vMRXkq/ZKhg34UflbPjy6HQt8esffPxV4Ge6vZemRZ BYEjnHJma6+7kMIP9CLh2ktRsQLixnx9aEqtIWgPq2KoKhjsDWFRnnqwuhqyLjDk+Van 9KdM8zTF4xMZ1oYmYRTk+UCP5sRt7SFuzBESncS7XcyZfqWjkghGHMksXbYGdILrBZ88 5hbLd7iSx3JhiozIolMNeHmhsAXPUIBs5HfkdmpLlwZCeAPd7v99Drcgfm8FAzH3ikiR GY/z7gnL37Sl80UXAy2CTTSBgiNm9VwU6wXHHm1oCFElJuPreZIAu0I7agiHpqvJ/7nr h6rQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714751219; x=1715356019; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+hxGtO3uIWBoJidluPklvlR8A24G9Z4q60k2CmruTiw=; b=kUHWuAaqM8kGo2mrknNl7u76S9PoWfcqMhy7rSBIPzNC5vGWEMh2oDPXWhUjRIYbHE 3jn9ztJ31kuPxCTVRl2k3wIeIa2lVrW4N4hH6Tkta60JlCuQ2llsS78BE1kywNs4FjVY mBoJTnnbd2D2TLkjjJdXeZjlWA3Ze/JXKOOGn8agGjOYOU8PQsDF2//tUbUTIWfn23B1 3yBeLyEREY69ngwdYHa0EiV6X2FgcM1Cix5YyN4wrGTWnHDFGNG6aqPXlbK6teB8Je+k 8MW628a5VoDJR5z3FSLNoL2IfaUsuKkYLnFED16jRcNfkPb7wf/JkXKqqErttxV5ZFEa HzFQ== X-Gm-Message-State: AOJu0YwdUAUwjtOc6dwKAjuP57pmYPQAP3l3D5JTOHMeD1rYgYIU6Qtc +zOL4TAOF3O/5cuBJTojmCyjB9zGSWjTfdVwLmJqukGwtNQfXlQBfwR1LFf8Z+lEYTI83zUCdZY = X-Google-Smtp-Source: AGHT+IHo9L5lW1AkpE8bc8oOgZWATw50sl1h6OyvHY0uTIf2w+SESCK9fg1paJzb9oIMIQIJwn8M8A== X-Received: by 2002:a05:6602:2153:b0:7de:d55f:c1d3 with SMTP id y19-20020a056602215300b007ded55fc1d3mr3454166ioy.17.1714751218693; Fri, 03 May 2024 08:46:58 -0700 (PDT) Received: from murgatroyd (97-122-86-252.hlrn.qwest.net. [97.122.86.252]) by smtp.gmail.com with ESMTPSA id gx10-20020a05663867ca00b004874d717cffsm842078jab.29.2024.05.03.08.46.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 May 2024 08:46:58 -0700 (PDT) From: Tom Tromey To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 3/3] Add symbol, line, and location to DAP disassemble result In-Reply-To: <20240430131702.218184-4-tromey@adacore.com> (Tom Tromey's message of "Tue, 30 Apr 2024 07:15:33 -0600") References: <20240430131702.218184-1-tromey@adacore.com> <20240430131702.218184-4-tromey@adacore.com> X-Attribution: Tom Date: Fri, 03 May 2024 09:46:57 -0600 Message-ID: <87r0eidhji.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom Tromey writes: Tom> The DAP spec allows a number of attributes on the resulting Tom> instructions that gdb currently does not emit. A user requested some Tom> of these, so this patch adds the 'symbol', 'line', and 'location' Tom> attributes. While the spec lets the implementation omit 'location' in Tom> some cases, it was simpler in the code to just always emit it, as then Tom> no extra tracking was needed. Tom> + if sal.line != 0: Tom> + result["line"] = str(sal.line) A co-worker noticed that this is emitting a string instead of a number, contrary to the spec. I've fixed this locally. Tom