From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by sourceware.org (Postfix) with ESMTPS id A9119384AB59 for ; Mon, 22 Apr 2024 16:07:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A9119384AB59 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A9119384AB59 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::1032 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713802056; cv=none; b=Lbi7cMLhO/Zl6WKIeW122kfvfCwJ/zdDEpGSMkw11o5Cq4ykbBV9YUKYt4rCamJRp4JgswFFi6y2lWAYpv9lmsd01ToZhDyS6ftTfDuRDhzmSaf8PWMCNBH/hnCFl3xaP2uBdz4/UgMccFhRraidU3H7F1Clg6BnXXEgN9gd6gc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713802056; c=relaxed/simple; bh=+4b276lPoCVs19fiqwj4JpI24fvJaMcBc8KYA1ktWlk=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=wPS6aZYRHc1PfgRWjQ819lFcFHjXqOClIoTuUHJzOFR1ttQtE+5aW5dUdmK8U93TqDUl/6iLIe5MRc0IFV2y33llnS3DZu2o2ykUOjw9oPdONMsK/7QcmLeeE5QI9wuWRPbK4O01Fvw1z42128tVhYqx/GREafR1EI37nokmD4k= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pj1-x1032.google.com with SMTP id 98e67ed59e1d1-2a2da57ab3aso3630026a91.3 for ; Mon, 22 Apr 2024 09:07:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713802048; x=1714406848; darn=sourceware.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=KaL1wIwY4F04RHnD2o0W8PPUZjtVjYac6FFO6P6pOEc=; b=U6KBhkZ3Csdt/1HH0cop/2IMID7tvv6szzj9uYeU5XKhzc4mANYoLcCnXdcvlY08eF Eg43vl+nV/GKfQeoq8CE64Mx02DZdPExPzJ7+tREK4qTwUmTTdQxVI5LNdNZSFcDrP7E NefgJD/fqUPFhLpnMb2UOA3Allpm4tgJqftKAy9MP9u/x7/rmJYj2Hv0+phUhBvVl0dJ gbnvmc01KOtFeDG8DPkhKaSc73Lcutw6IcUnvkXUPukNHANaLUNS66d+0DTBBtcY0lLw IMEeJZJzz1hQgeD+Tp1Or4jo6gMyGlICz1WlIOWnhItShLmzqv+7+k5ywXi/cLrQypGa bKDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713802048; x=1714406848; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KaL1wIwY4F04RHnD2o0W8PPUZjtVjYac6FFO6P6pOEc=; b=o+w65gNNAXiP/f7XCSYA4xjK40FMx9K2envPcqw4bgFV9mbRbKWEHAaO9hvnjKtmw+ TUcEQnFqwa0PcOex39QSL4pVncifZPak4QLX3/JVwDJDFmDaa4y4cagfgoRFPQQbpa7e 2IN5JBOspxPGy14Nds5FE25GnbxCU9VTAPBDPFdJL+68erNHG5eQ/6Nu0ZdbNikcGqUS 8w8q0TyXCYHcfZuLsjLB+w/t9Vwnv16hzTVKDBrQHZJR0BcnCvob420jWLtaU5Ujl61b y+Gc5dmkKVab+JAXL0Tt+zUaWT7AUHUhUuBfzw0MXW7WMRWcVARthZe5QKiYTXPwsDAV 87zQ== X-Gm-Message-State: AOJu0Yws/VpY2cigLcnfN4xZCK0V5q/oZnkHHvj9xPGZfIQcdDTrX5W9 REM8C74hQmvc1uqjjB2WH+jbYDiZ+ctTnsf2Xep2acwuvORiQvLntJ2tk0rcxcs7bnpd/5Ob4Ai 1 X-Google-Smtp-Source: AGHT+IG18BIsxBZT3duDGsqbQlzEC07x/jY5Tq6JNWHElFy0JsXaVf/oghjcXjczElu1c1QAg741lQ== X-Received: by 2002:a17:90b:203:b0:2ad:e61b:92a6 with SMTP id fy3-20020a17090b020300b002ade61b92a6mr2967633pjb.6.1713802048529; Mon, 22 Apr 2024 09:07:28 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8470:87aa:da06:1597:160d]) by smtp.gmail.com with ESMTPSA id ns5-20020a17090b250500b002a5f44353d2sm9797092pjb.7.2024.04.22.09.07.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Apr 2024 09:07:28 -0700 (PDT) From: Thiago Jung Bauermann To: Luis Machado Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 2/2] gdb/testsuite: Add gdb.base/memops-watchpoint.exp In-Reply-To: (Luis Machado's message of "Mon, 22 Apr 2024 15:39:06 +0100") References: <20240421222657.1052635-1-thiago.bauermann@linaro.org> <20240421222657.1052635-3-thiago.bauermann@linaro.org> User-Agent: mu4e 1.12.4; emacs 29.3 Date: Mon, 22 Apr 2024 13:07:25 -0300 Message-ID: <87r0ex2xfm.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello Luis, Thanks for reviewing the patches! Luis Machado writes: > On 4/21/24 23:26, Thiago Jung Bauermann wrote: >> +setup_kfail breakpoints/31665 arm*-*-linux* >> +gdb_test "continue" \ >> + [multi_line \ >> + "Continuing\\." \ >> + "" \ >> + "(Hardware w|W)atchpoint ${decimal}: -location a\\\[28\\\]" \ >> + "" \ >> + "Old value = 104 'h'" \ >> + "New value = 0 '\\\\000'" \ >> + ".*memset.* \\(\\) at .*:$decimal" \ >> + ".*"] \ >> + "continue until memset watchpoint hits" >> + >> +setup_kfail breakpoints/31665 arm*-*-linux* >> +gdb_test "continue" \ >> + [multi_line \ >> + "Continuing\\." \ >> + "" \ >> + "(Hardware w|W)atchpoint ${decimal}: -location b\\\[28\\\]" \ >> + "" \ >> + "Old value = 101 'e'" \ >> + "New value = 114 'r'" \ >> + ".*memcpy.* \\(\\) at .*:$decimal" \ >> + ".*"] \ >> + "continue until memcpy watchpoint hits" >> + >> +# Note: Some architectures use memcpy for memmove. >> +setup_kfail breakpoints/31665 arm*-*-linux* >> +gdb_test "continue" \ >> + [multi_line \ >> + "Continuing\\." \ >> + "" \ >> + "(Hardware w|W)atchpoint ${decimal}: -location c\\\[28\\\]" \ >> + "" \ >> + "Old value = 100 'd'" \ >> + "New value = 114 'r'" \ >> + ".*(memmove|memcpy).* \\(\\) at .*:$decimal" \ >> + ".*"] \ >> + "continue until memmove watchpoint hits" > > For this test, on aarch64 I see full passes, but on 32-bit Arm I see > 3 passes and 3 kfail's. > > Is that the expected outcome? Yes, the testcase uncovered a bug in in hardware watchpoints with 32-bit Arm (the testcase fully passes when the testcase is modified to use software watchpoints) so I opened PR breakpoints/31665 to track it. I didn't have the chance to investigate the problem yet, but it's in my TODO list. -- Thiago