From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x12b.google.com (mail-il1-x12b.google.com [IPv6:2607:f8b0:4864:20::12b]) by sourceware.org (Postfix) with ESMTPS id 7EAF93858CD1 for ; Mon, 11 Mar 2024 20:26:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7EAF93858CD1 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7EAF93858CD1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::12b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710188766; cv=none; b=chL4vC7KIWiBm/aSIZx24GfQA/GgGJcMxcyEZ9Iz6fATRTyLGmdYjv5CClLpiBNd5vIjRvNP/XzasmO37dPM7METn7o4asqEK/9k0FZfRBzkTGuiGFY2PnCkJGFhxL/hb70bGae47OobBa9tan9zB2XQoMwSsDhLW1b5/fywJms= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710188766; c=relaxed/simple; bh=SKA2NQF9q8+YxyGALHJbO21NjDZd9UXUfzwWjYN2AmQ=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=TgAdk8IpKNVJeAvHhYIM3ugujrQK9+55HI5mbpJwAshjpwUThsZdX6CJUUzbNsve3rCUsmJchBlK7dox1+jH2m3j2N9kN6zBBPEJNsrjNrmLuyZW3tTS2GiC4v8pkAgrmdEEVY/RQtIdFnEEv4HhgI7V/P0DUP00rGQshbnORtg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-il1-x12b.google.com with SMTP id e9e14a558f8ab-366349042f5so16370295ab.2 for ; Mon, 11 Mar 2024 13:26:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1710188764; x=1710793564; darn=sourceware.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=I0pj7sPjbEQh5MnWNOKsANZjG1I0/UGQmRgKqBDuIGQ=; b=ItxBOAZ8WqJUrAQzzGtXrRdjVYusUtL3GM/2qsi3vP6iNQ6Wf1PaJWllrvdjYoeVBR Ad4rnZZpW3M7G0g9J1GygYiV/+TXNnMsMVADabWXawLLQ2yChX+8icWB+tGT8WH/V049 ygSXb7nfqX/GsVfUE1GTb1shiIZWgN3nEazpKMuHDK6TaQVATAO46sovDIz/3ZfHJC5e 8HKXim7j1QVg7YJj+zbCF3SSRMx6vZKy5+RUXUr79pYzFfQ07aiz5LksxIHWSO3wxGkr rrGQsZvMM8C4e1n8oTJM1YTHeMeI//XUqXgvSzBg7zNjT2VentuW4OVChHKYm1Imqpme sSCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710188764; x=1710793564; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=I0pj7sPjbEQh5MnWNOKsANZjG1I0/UGQmRgKqBDuIGQ=; b=KmnN1i1l24B6NfkNZkd1vJFDkrTHtGXLEhIhynzIT6OAKwq9Bony2Z6kagctb/TxpJ /Fjn7GzZ+1uJoZ8qQGQVcUtkPzJWlTlZ2BvNE7qV5fJEDdFUvVhEMg74Wku8vjoJeClk yBK+LXHAssesXtSu71FM0QlbtkIZwSKp0+dQyVjw2NsWIENIzT/I3ndXdbmPkkXwrT8d wPhyc2HL4+36cYxuDHfjHvJtJvuzaF52+m+feSLeOwm+PAIVCvEn/C3q4/tk9oMo/hyx bo2nc9pTz1jvfDCZluVtcMyvnJxPZCIGnpV0ESNQ/O1QxuZnSkrmGixYoASCtEXRHDQu gtJQ== X-Gm-Message-State: AOJu0Yzo0y6t21+UFwUiw8UcvZV7R/Rr6vA2Assy4rwyNlLGDOLEHiYZ VoCsF4KG5YFx/FZFZ5G+OwmzCuEbYgH6dBamznPnL7Ozw4aEzFtF+Ou2QOP/1zqzjDrpXLfvMIo = X-Google-Smtp-Source: AGHT+IEdloLnxc6YjO8Hd55UFOIrgEjED/dkYkYsRq3PO7x6YYj4AWnrQkxlFFiHpW0vKFsdwmBsPw== X-Received: by 2002:a05:6e02:1d87:b0:366:4844:dedc with SMTP id h7-20020a056e021d8700b003664844dedcmr6055160ila.24.1710188764754; Mon, 11 Mar 2024 13:26:04 -0700 (PDT) Received: from murgatroyd (97-122-82-115.hlrn.qwest.net. [97.122.82.115]) by smtp.gmail.com with ESMTPSA id c3-20020a92c8c3000000b00365ab9e9799sm1893788ilq.79.2024.03.11.13.26.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Mar 2024 13:26:04 -0700 (PDT) From: Tom Tromey To: Simon Marchi Cc: gdb-patches@sourceware.org, binutils@sourceware.org Subject: Re: [PATCH] gdb: add .pre-commit-config.yaml References: <20240311150947.71762-1-simon.marchi@efficios.com> X-Attribution: Tom Date: Mon, 11 Mar 2024 14:26:03 -0600 In-Reply-To: <20240311150947.71762-1-simon.marchi@efficios.com> (Simon Marchi's message of "Mon, 11 Mar 2024 11:09:43 -0400") Message-ID: <87r0ggo6qs.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> Simon Marchi writes: > Using pre-commit to run hooks is opt-in, as in it's not mandatory at all > for development Important point for binutils. > I have not used pre-commit in a real project before, but have heard good > things from it. We use it internally at AdaCore. It seems totally fine, I've rarely had any issue with it, and it's pretty easy to bypass should the need arise. So, +1 from me. thanks, Tom