From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd36.google.com (mail-io1-xd36.google.com [IPv6:2607:f8b0:4864:20::d36]) by sourceware.org (Postfix) with ESMTPS id C4D01385842D for ; Thu, 14 Dec 2023 19:06:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C4D01385842D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C4D01385842D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d36 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702580822; cv=none; b=weeMSZW+DY9hBrsqe3zMCwh4AWhcezxGb9gsMVuA0uODPwIxDr3z/tHMKG098DJGMc9MRHCQtXxCVM95N9q4ZHz7eSlntNHXquQ4I3nqtCOiCVi2tgJBtoSqz5CicN0TYkH3GNoB/cwbRnEvIeF6skMPpXOFfy7WJ3HAHrzUy4g= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702580822; c=relaxed/simple; bh=AmRLf19lR9ls9WTwjpmRPanXfIdSlDovKZz709OAeSg=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=eC1j/c9rKgwdL3R9JimMOC2q36LdWjEH2T2eCcFl5rJahVRrga+2XYmNIZmD3WD+8JLPibi+sDswhuX7/vPcTbdumj9GpOI+D8ku5wzoz/DX88PhsWGSzv2ap/6s7bE8mcNDqi4O8NBHMfe6C6K8gF95M6qc+F99hmbZQMA74Tg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-io1-xd36.google.com with SMTP id ca18e2360f4ac-7b771176f80so172526739f.2 for ; Thu, 14 Dec 2023 11:06:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1702580811; x=1703185611; darn=sourceware.org; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=AmRLf19lR9ls9WTwjpmRPanXfIdSlDovKZz709OAeSg=; b=XCeaq83ZAnN/zGR3ceQi4Mb7HkPggzewI7pHYMEBmK1aJQ5eqtrHX9qbK9bC2i7RaH UXggznbsLBtp6PpLApv5E4B9mnq/ELCESuheDWyJ46ESvUxdG4HPrxEWuLUG2p6AjLGX 6atnSeS//LgvCQ3Vz57bMyzwOv0iEnMEih5kxmrMHn6Kg8kYYp0SqYt7Kj1s8PBNhXR8 iYqPQ3nEbczpmzAHTMYlfriTCdyHyTHjFRy+8kzYhj9eZYHF7uNldqcbnZ3kKAwZi5HR 8LDaYYIXRDi8/vGSZgScxJVKJGxB3V5lQVyR8Mc3lhVwCugnWWrKV12Spv7I7OgGA6A5 XnGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702580811; x=1703185611; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=AmRLf19lR9ls9WTwjpmRPanXfIdSlDovKZz709OAeSg=; b=pgi95GWLsVrswBDVrbKIjjI74LrCAiy1fR8d8Ld4QgnzotMtEGXkmgu7+rhFYVKNd7 uAk59W/SMxrYR2IxY2MyaywwdKWq29i7htkf1A/y9tBC2U9n3vwrSi0z79hoTA6L+k/U +yexwGWxQmXKZ3W7UgZjtaGWzr++GXCLwZ0j2MfotO7EaqAmEP0bQ6lzOe0I/mjvBJdP 5RqONcbhNy4THBp5Iyvl1FViJQLB+RSB2gIo9I9xkNO5LxPNr8VVjAILRQr9QIKwfytn tuSZAvEQxIhTrNmBi4o9NLzE3QJvwQ0uVKpmL5vgbwWAjktd8WDgaPqwZF6w75ogARpO lssA== X-Gm-Message-State: AOJu0YwVhw/p8s0OFvsC631vMN8yGM+FIAxYcbgalTK0w5gfeHPLoBqi sg3KnzMVfAouhYaiJEdKI8mno/iU/p/ZHYF5V34= X-Google-Smtp-Source: AGHT+IEJKxstkWsRWJTa1DGgN5Lq29iQ4abdva0XCQgaAaKJW4O2CseBOu4TIzSNDFYCC9C6cmNcOw== X-Received: by 2002:a05:6602:2bd4:b0:7b6:fb93:89a8 with SMTP id s20-20020a0566022bd400b007b6fb9389a8mr9163123iov.31.1702580810954; Thu, 14 Dec 2023 11:06:50 -0800 (PST) Received: from murgatroyd (71-211-161-25.hlrn.qwest.net. [71.211.161.25]) by smtp.gmail.com with ESMTPSA id p8-20020a0566380e8800b0046926dafa32sm3533707jas.135.2023.12.14.11.06.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 11:06:50 -0800 (PST) From: Tom Tromey To: =?utf-8?Q?K=C3=A9vin?= Le Gouguec Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 2/4] Add DAP log level parameter References: <20231212-dap-no-test-exceptions-v1-0-af0e33f10093@adacore.com> <20231212-dap-no-test-exceptions-v1-2-af0e33f10093@adacore.com> <87plza3vrt.fsf@adacore.com> X-Attribution: Tom Date: Thu, 14 Dec 2023 12:06:49 -0700 In-Reply-To: <87plza3vrt.fsf@adacore.com> (=?utf-8?Q?=22K=C3=A9vin?= Le Gouguec"'s message of "Wed, 13 Dec 2023 17:35:50 +0100") Message-ID: <87r0jo8uye.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "K=C3=A9vin" =3D=3D K=C3=A9vin Le Gouguec wri= tes: K=C3=A9vin> I might suggest an enum here: ... K=C3=A9vin> But the benefits of Python enums are somewhat marginal (even mo= re so in K=C3=A9vin> this instance; FWIW I _think_ IntEnum & auto are all available = since K=C3=A9vin> 3.4), so no strong feelings about this. I went ahead and did it, it seems a little nicer maybe. Tom