From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta37.uswest2.a.cloudfilter.net (omta37.uswest2.a.cloudfilter.net [35.89.44.36]) by sourceware.org (Postfix) with ESMTPS id 7408F3858414 for ; Wed, 30 Aug 2023 20:17:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7408F3858414 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from eig-obgw-5009a.ext.cloudfilter.net ([10.0.29.176]) by cmsmtp with ESMTP id bOXjqVw1kQFHRbRdEqnrYF; Wed, 30 Aug 2023 20:17:40 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id bRdDq97RgdHUSbRdDqkIow; Wed, 30 Aug 2023 20:17:40 +0000 X-Authority-Analysis: v=2.4 cv=Y53rDzSN c=1 sm=1 tr=0 ts=64efa3e4 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=UttIx32zK-AA:10 a=Qbun_eYptAEA:10 a=CCpqsmhAAAAA:8 a=75FAf6A6GYzAqeeAwkAA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=MrUXAUteLO48KH8kQ6doWFq9ulPauhh7oyo2EPkJKCA=; b=pTFw9L8UfdZhojqgf3JvlPQK3Y 4Uij+W/iTZ0fS+TXHELDUgUSf786to4UnuOpaDGlQ0h726hqgIoY0sIZy4FCAUBf54ORfoE2ntwxx UeJa486G+Ds6n4y3inza5aFzn; Received: from 75-166-150-212.hlrn.qwest.net ([75.166.150.212]:39232 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qbRdD-0043Qr-0v; Wed, 30 Aug 2023 14:17:39 -0600 From: Tom Tromey To: Tom de Vries via Gdb-patches Cc: Tom de Vries Subject: Re: [PATCH 2/6] [gdb/symtab] Factor out type::{alloc_fields,copy_fields} References: <20230830191336.15885-1-tdevries@suse.de> <20230830191336.15885-2-tdevries@suse.de> X-Attribution: Tom Date: Wed, 30 Aug 2023 14:17:38 -0600 In-Reply-To: <20230830191336.15885-2-tdevries@suse.de> (Tom de Vries via Gdb-patches's message of "Wed, 30 Aug 2023 21:13:32 +0200") Message-ID: <87r0nkqo7x.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.150.212 X-Source-L: No X-Exim-ID: 1qbRdD-0043Qr-0v X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-150-212.hlrn.qwest.net (murgatroyd) [75.166.150.212]:39232 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfHzFIm+tqrN1UT56pm1Qw+mPatslz6xLvjL/uU1L5n1gaaSxfYl0rp2V+8gsJZBYqf41hggolm72UpxprhwAYGR9N5ZUTvjKLldsvSlccN2o8PLNdXBb dFRatzhcRTPOOaaAlQMBcEKrjzMaxiWqRYJAJmP5gwH4w0d/VJ97YqzPBVpA+t4yad120mqs8FfB4nIqnYB1Ilut0JPuqlXZp5Y= X-Spam-Status: No, score=-3019.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom de Vries via Gdb-patches writes: Tom> After finding this code in buildsym_compunit::finish_block_internal: Tom> ... ftype-> set_fields Tom> ((struct field *) Tom> TYPE_ALLOC (ftype, nparams * sizeof (struct field))); Tom> ... Tom> and fixing PR30810 by using TYPE_ZALLOC, I wondered if there were more Tom> locations that needed fixing. Tom> I decided to make things easier to spot by factoring out a new function Tom> alloc_fields: Thanks. Seems like a good idea to me. Tom> +void type::alloc_fields (unsigned int nfields, bool init) gdb style is a newline after the return type. There's a few cases of this. Tom