From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 776B83858C53 for ; Fri, 25 Aug 2023 14:49:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 776B83858C53 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692974945; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FO98AzqdqNjMtRNFETT3Dr5zYqLGAGk47lR15Wlilyw=; b=O3FMNOLRwmu+MdaJFPusdXzNZPkyvsPIZR1F+d8bDjcKbH2TZ6/mYZcu83baEGmV821WuM hHya80ZMiAclmGrYodSOIKs5vUBOWQh7VXLZsSg9R1ZK7hrJpVZ1w5KPqXNMWHbJP+FtE6 GTRKjYq0TwpoaGt8Ikm3BvipFWDDC8I= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-644-MGZe_u5fO-inK3-8BKj0ZA-1; Fri, 25 Aug 2023 10:49:03 -0400 X-MC-Unique: MGZe_u5fO-inK3-8BKj0ZA-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-3fef698fb3cso6768665e9.1 for ; Fri, 25 Aug 2023 07:49:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692974942; x=1693579742; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FO98AzqdqNjMtRNFETT3Dr5zYqLGAGk47lR15Wlilyw=; b=arCH23NlEehaLoHPV+updnrTRbsMrW4IPwGY9H4iFiVCu0NicNi9Wkc5HoIJhsNyPE DKQoBQlO9GlbN4ZxGODmW2z3B3i/g1YgEetWGcQQvoMOByopX6Rqdeo9ij3ESwNHP7cV +REkWZ8Phy80Uf7GIrz7IASoZgumanBPkKHHe5QhTeAcrHmtPwQ4OaZVSZDsCtjZrxSv ZOrPj7pi3JNfjrdFWRa+mL9ikQSSn4Lz31jj2yHp8u+Y1Fo58AzaNn0He+vdeH4t6HQF c8nYAxYqM6tlPRNwUYGm9D+TVnOZqCZh+/MHsj1D/ym5DdOi7asld8nqMXbNjzTKoEma eI5g== X-Gm-Message-State: AOJu0YzuJUm5lsg6y296hXltUSHJ6p/DIIQ4el3QBk+u+bybDaU9IvOw A8qge0AP99JEGl4f+PeMWHhzPnhELJfinjp8eUtiRP0P5FbaxSsgYTuaeO6OE2g/iebhdp28IgC ELxbpLfG9iS4D+f1wXi4iEw== X-Received: by 2002:a05:600c:2491:b0:3fe:da37:d59 with SMTP id 17-20020a05600c249100b003feda370d59mr5208113wms.4.1692974942426; Fri, 25 Aug 2023 07:49:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFwN+CFaoamyA41R/y542a9dYGJNqU3nEhQHqMPoRMZE9TL+exbSqdUJydso+hiOglnrQ+ang== X-Received: by 2002:a05:600c:2491:b0:3fe:da37:d59 with SMTP id 17-20020a05600c249100b003feda370d59mr5208100wms.4.1692974942064; Fri, 25 Aug 2023 07:49:02 -0700 (PDT) Received: from localhost ([31.111.84.232]) by smtp.gmail.com with ESMTPSA id q20-20020a7bce94000000b003fedcd02e2asm2394026wmj.35.2023.08.25.07.49.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Aug 2023 07:49:01 -0700 (PDT) From: Andrew Burgess To: Eli Zaretskii Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 07/10] gdb: add qMachineId packet In-Reply-To: <83y1ib6j5x.fsf@gnu.org> References: <94e68e6c1400ede2e9e46fc8ef76bd82aa533e0e.1692200989.git.aburgess@redhat.com> <83y1ib6j5x.fsf@gnu.org> Date: Fri, 25 Aug 2023 15:49:00 +0100 Message-ID: <87r0nr9nz7.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Eli Zaretskii writes: >> Cc: Andrew Burgess >> Date: Wed, 16 Aug 2023 16:55:03 +0100 >> From: Andrew Burgess via Gdb-patches >> >> diff --git a/gdb/NEWS b/gdb/NEWS >> index 9839330c46d..d83f097d937 100644 >> --- a/gdb/NEWS >> +++ b/gdb/NEWS >> @@ -272,6 +272,11 @@ qDefaultExecAndArgs >> which the server was started. If no such information was given to >> the server then this is reflected in the reply. >> >> +qMachineId >> + This packet returns an identifier that allows GDB to determine if >> + the remote server and GDB are running on the same host, and can see >> + the same filesystem. >> + >> *** Changes in GDB 13 > > This part is OK. > >> @@ -44748,6 +44749,49 @@ >> Indicates an error was encountered. >> @end table >> >> +@anchor{Machine-Id Packet} >> +@item qMachineId >> +@cindex query remote machine-id, remote request >> +@cindex @samp{qMachineId} packet > > Please move the @cindex entries before the @item line, so that > index-search in an Info reader lands you on the line corresponding to > @item, not on the text after that. > >> +within a single reply. See @ref{Machine-Id Details} for details of > ^ > Comma there, please (it is needed for some older versions of Texinfo). Thanks for the feedback, I'll get that fixed. > Btw, when a sentence starts with "See @ref", you could simplify by > using @xref, as that is its main purpose. When generating the 'info' docs @xref doesn't add the 'See' prefix, but when generating the pdf 'See' is added. I guess this explains why 'See @ref' is common throughout the GDB manual. It seems strange the prefix is added in some contexts, but not in others. The info docs don't seem to read as clearly without the 'See' prefix, so for me at least, @xref seems the worse choice. My question is, what am I missing here? I'm sure there's some logic behind this difference, but I'm not seeing it. Thanks, Andrew