From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from qproxy3-pub.mail.unifiedlayer.com (qproxy3-pub.mail.unifiedlayer.com [67.222.38.20]) by sourceware.org (Postfix) with ESMTPS id EAA763858C20 for ; Mon, 14 Aug 2023 16:08:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EAA763858C20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from progateway7-pub.mail.pro1.eigbox.com (gproxy5-pub.mail.unifiedlayer.com [67.222.38.55]) by qproxy3.mail.unifiedlayer.com (Postfix) with ESMTP id E453A80330C9 for ; Mon, 14 Aug 2023 16:08:09 +0000 (UTC) Received: from cmgw11.mail.unifiedlayer.com (unknown [10.0.90.126]) by progateway7.mail.pro1.eigbox.com (Postfix) with ESMTP id D64401004742A for ; Mon, 14 Aug 2023 16:07:39 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id Va6VqZZ2BGB7oVa6VqXqHg; Mon, 14 Aug 2023 16:07:39 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=LYT5VhTi c=1 sm=1 tr=0 ts=64da514b a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=UttIx32zK-AA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=zstS-IiYAAAA:8 a=75FAf6A6GYzAqeeAwkAA:9 a=ul9cdbp4aOFLsgKbc677:22 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Lc1fo4ZeGPapXt8FWhMuxZt2FJz9Ztks2gjLNyBRgrs=; b=AdotCEZhPkRSmGDnHPEf4YyXUf 9JGtU3APU21E8W7dMUTwJnMWXtLYCWxU7Bj3RooSEXkQA5gBd6hoSwR9EhRi9hSArg/LS9ZNaVHVN cZ65ufBd5/0e8fkRgJIzbEEMc; Received: from 75-166-142-177.hlrn.qwest.net ([75.166.142.177]:46150 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qVa6V-002adG-1p; Mon, 14 Aug 2023 10:07:39 -0600 From: Tom Tromey To: Tom de Vries via Gdb-patches Cc: Tom de Vries Subject: Re: [PATCH 2/4] [gdb/build] Fix enum param_types odr violation References: <20230814111721.31402-1-tdevries@suse.de> <20230814111721.31402-2-tdevries@suse.de> X-Attribution: Tom Date: Mon, 14 Aug 2023 10:07:39 -0600 In-Reply-To: <20230814111721.31402-2-tdevries@suse.de> (Tom de Vries via Gdb-patches's message of "Mon, 14 Aug 2023 13:17:19 +0200") Message-ID: <87r0o5zjxw.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.142.177 X-Source-L: No X-Exim-ID: 1qVa6V-002adG-1p X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-142-177.hlrn.qwest.net (murgatroyd) [75.166.142.177]:46150 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3018.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom de Vries via Gdb-patches writes: Tom> When building gdb with -O2 -flto, I run into: Tom> ... Tom> gdb/guile/scm-param.c:121:6: warning: type 'param_types' violates the C++ \ Tom> One Definition Rule [-Wodr] Tom> enum param_types Tom> ^ Tom> gdb/python/py-param.c:33:6: note: an enum with different value name is \ Tom> defined in another translation unit Tom> enum param_types Tom> ^ Tom> ... Tom> Fix this by renaming to enum scm_param_types and py_param_types. Looks good, thanks for taking this on. Perhaps the -Wodr patches should link to the ODR bug. Approved-By: Tom Tromey Tom