From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy4-pub.mail.unifiedlayer.com (gproxy4-pub.mail.unifiedlayer.com [69.89.23.142]) by sourceware.org (Postfix) with ESMTPS id 3C0563858C41 for ; Mon, 7 Aug 2023 22:16:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3C0563858C41 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw10.mail.unifiedlayer.com (unknown [10.0.90.125]) by progateway6.mail.pro1.eigbox.com (Postfix) with ESMTP id A3F8810047D61 for ; Mon, 7 Aug 2023 22:16:20 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id T8WSqrhA86i54T8WSqP8ad; Mon, 07 Aug 2023 22:16:20 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=QsWbYX+d c=1 sm=1 tr=0 ts=64d16d34 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=UttIx32zK-AA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=YsFzmg9a51a4FIv_o4QA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=hAdUzcjtvdD9ydNX+5VQtaRLD0RP/NO0c9p/WwSVHDc=; b=SF8YUhArVSwaElH0a/NOLWx6Et nPa9bMwI43hCXC60myjzpn2cf3GhlmDs92iPdTEbk25h2Fk8vicWrVBg9Ee9td4sSMrFhzwiHkbhx nQwkRQDxgWs6rNFE1P5jOtvMn; Received: from 71-211-152-221.hlrn.qwest.net ([71.211.152.221]:37884 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qT8WS-002tCO-1F; Mon, 07 Aug 2023 16:16:20 -0600 From: Tom Tromey To: Simon Marchi Cc: Tom de Vries , Tom de Vries via Gdb-patches , Tom Tromey Subject: Re: [PATCH] [gdb/build] Fix build breaker with -std=c++11 References: <20230806235915.18746-1-tdevries@suse.de> <51561E9D-24F0-48CB-A563-50F29C2966D9@polymtl.ca> X-Attribution: Tom Date: Mon, 07 Aug 2023 16:16:19 -0600 In-Reply-To: <51561E9D-24F0-48CB-A563-50F29C2966D9@polymtl.ca> (Simon Marchi's message of "Mon, 07 Aug 2023 10:35:55 -0400") Message-ID: <87r0oe7b2k.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.152.221 X-Source-L: No X-Exim-ID: 1qT8WS-002tCO-1F X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-152-221.hlrn.qwest.net (prentzel) [71.211.152.221]:37884 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3018.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Simon> When we encounter things like this, should we add some greppable Simon> TODO comment to record an actionable item for when we switch to a Simon> more recent C++ version? FWIW I know of one other instance of this, in gdb_demangle: std::string copy = name; run_on_main_thread ([=] () { report_failed_demangle (copy.c_str (), core_dump_allowed, Here, the name is copied twice, but with move captures there could be just a single copy. I wonder when we can switch to C++14. Tom