From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy2-pub.mail.unifiedlayer.com (gproxy2-pub.mail.unifiedlayer.com [69.89.18.3]) by sourceware.org (Postfix) with ESMTPS id 2B6283858D32 for ; Mon, 10 Jul 2023 17:25:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2B6283858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw12.mail.unifiedlayer.com (unknown [10.0.90.127]) by progateway4.mail.pro1.eigbox.com (Postfix) with ESMTP id 53B8B10043B40 for ; Mon, 10 Jul 2023 17:25:39 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id IudnqO2d55FhmIudnqaVnj; Mon, 10 Jul 2023 17:25:39 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=Vpnmv86n c=1 sm=1 tr=0 ts=64ac3f13 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=ws7JD89P4LkA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=TPQyHb7lI_l7aVj4jNgA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=lgJZUMLoVDnu5Qe2NFSiwoZLf5FG58NiHoCDjQ2bAdk=; b=aCRcZna8KEh5dgRHzBOCFQhaZf Gr8F1IRZfOm7/Mw7VHVoPfxSMslw4t6FI6xkZudVuZCQC/ZjpycLY+00YlEm7YgrlkxSpmdg7mjcq V87GzogKshKTZ8Xb8n+j4Tq2m; Received: from 75-166-135-140.hlrn.qwest.net ([75.166.135.140]:33922 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qIudn-001kng-00; Mon, 10 Jul 2023 11:25:39 -0600 From: Tom Tromey To: Andrew Burgess via Gdb-patches Cc: Tom Tromey , Andrew Burgess Subject: Re: [PATCH 5/5] gdb: make deprecated_show_value_hack static References: <6fddb814d85dcacfcd3de87404b722d52edcc89e.1680608960.git.aburgess@redhat.com> <87pm8231gr.fsf@tromey.com> <87ttx09hrl.fsf@redhat.com> X-Attribution: Tom Date: Mon, 10 Jul 2023 11:25:38 -0600 In-Reply-To: <87ttx09hrl.fsf@redhat.com> (Andrew Burgess via Gdb-patches's message of "Fri, 28 Apr 2023 15:57:18 +0100") Message-ID: <87r0pfr84t.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.135.140 X-Source-L: No X-Exim-ID: 1qIudn-001kng-00 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-135-140.hlrn.qwest.net (murgatroyd) [75.166.135.140]:33922 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3019.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Andrew" == Andrew Burgess via Gdb-patches writes: >> FWIW I wouldn't mind if we removed nearly all "show" functions and just >> made some variant of deprecated_show_value_hack the standard way to >> print things. Instead of munging the help text (which is >> i18n-unfriendly) it could just print the option name: >> >> (gdb) show mumble var >> Current setting of "mumble variable": 23 Andrew> I have a branch which I occasionally work on which is filling in all the Andrew> missing show functions -- which is the opposite to what you are Andrew> suggesting. Forgot to reply to this when you first sent it. For me the attraction of removing these is that it simplifies things -- less code, less to get wrong. Maybe it would require us to also regularize & automate the "auto means xyz in this context" concept, but that would also be beneficial (I think there's a bug in the Python component about this). I also don't really mind having a "computer-ish" output format here, as opposed to natural language text. However if you want to do it the other way, that's also fine. Tom