From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id E81623858D39 for ; Wed, 24 May 2023 17:39:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E81623858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684949957; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=h7Je1R5hFLeQHr/Cj130mrpJlRHFMtuN25r8rZZbkLQ=; b=ETEMbBx/SlZgqR1PtraA8wnkfQ8AVkgSCdprCAzb0YrxcY4k6rtie6nlvWIH0I8wZyyCbe +Au1UAlurPhurUzttvTaN1zz840UDUSfjphgmJqza2Y2P5lXLbRPMjMIamsrrUvb44VfXg cFDGMHULokaSpLMkHCitynTeqK2hLWo= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-322-PoW1KthuPY6X0NwTPPxXUg-1; Wed, 24 May 2023 13:39:16 -0400 X-MC-Unique: PoW1KthuPY6X0NwTPPxXUg-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-309542498deso38089f8f.0 for ; Wed, 24 May 2023 10:39:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684949954; x=1687541954; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=h7Je1R5hFLeQHr/Cj130mrpJlRHFMtuN25r8rZZbkLQ=; b=Uqc1vFPBtFb884qXaf1yTakEf5SzM6VoiuxtAtSX4KBllvD4L0/vxCPPI47lp5/QCH 9wOwIP2I4rdzFjqhO3w1nyc5EDGviHgxBw+GSLeONnzWQJYtlSoU9DCclVXLrS8V6EWL i/LzSSARmC/m01glCjqwMLkHx1oDHq4g3+mozB8eWr4ykDQMhN9Tls1z0zW9ILsXvZhu f4EKzNx5EkZwRa3p2tzfde1J7wmOlD3uyMGME8zt2p8k3/aBly310ix0xqofHQt9DsHm kRNcLbqhXiIO/rAOKeV8A/q3KY42XkJKKXS7PPFc8L+2+s4x1baOarMTkVwlcqMusL3m R5jA== X-Gm-Message-State: AC+VfDwaO2ItLvofpFfM5ZyKIhwVZ/RmkjXWdM6OKe8f5hkOCCFBIPuk 9WVd/50UJ3xkgnmM632v3f3uMC28kD/FBHUEVN9v9iTZMrXtaIGlLw/h1QzILVlrWcTwW6dLZCK okKOfoGYLL1L92uIolNGDVc9xmDUy4w== X-Received: by 2002:a5d:504f:0:b0:307:bb47:75de with SMTP id h15-20020a5d504f000000b00307bb4775demr67762wrt.26.1684949954702; Wed, 24 May 2023 10:39:14 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5rJorbsVAwqcEn08YlMqqI9giKJ+Cty8PWlXes6Klv184c97BbLPfYSgWbYw3bDKfBDjFnPA== X-Received: by 2002:a5d:504f:0:b0:307:bb47:75de with SMTP id h15-20020a5d504f000000b00307bb4775demr67753wrt.26.1684949954405; Wed, 24 May 2023 10:39:14 -0700 (PDT) Received: from localhost (11.72.115.87.dyn.plus.net. [87.115.72.11]) by smtp.gmail.com with ESMTPSA id o9-20020adfeac9000000b0030633152664sm15207051wrn.87.2023.05.24.10.39.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 May 2023 10:39:13 -0700 (PDT) From: Andrew Burgess To: Tom de Vries , gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/testsuite: fix race in gdb.server/multi-ui-errors.exp In-Reply-To: References: <21d9b41b65c9215cc3fd387e20934ad174e57203.1684945721.git.aburgess@redhat.com> Date: Wed, 24 May 2023 18:39:12 +0100 Message-ID: <87r0r5633z.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tom de Vries writes: > On 5/24/23 18:29, Andrew Burgess wrote: >> After this commit: >> >> commit ed32754a8c7919feffc6ddb66ff1c532e4a4d1cd >> Date: Thu Mar 9 10:45:03 2023 +0100 >> >> [gdb/testsuite] Fix gdb.server/multi-ui-errors.exp for remote target >> >> I noticed the occasional failure in gdb.server/multi-ui-errors.exp, >> which looked like this: >> >> (gdb) PASS: gdb.server/multi-ui-errors.exp: interact with GDB's main UI >> interrupt >> (gdb) >> Program received signal SIGINT, Interrupt. >> 0x00007ffff7d501e7 in nanosleep () from /lib64/libc.so.6 >> FAIL: gdb.server/multi-ui-errors.exp: interrupt (timeout) >> PASS: gdb.server/multi-ui-errors.exp: interrupt arrived >> p server_pid >> $1 = 718174 >> (gdb) PASS: gdb.server/multi-ui-errors.exp: p server_pid >> >> This is triggered by this code in gdb.server/multi-ui-errors.exp: >> >> gdb_test "interrupt" >> >> gdb_test_multiple "" "interrupt arrived" { >> -re "Program received signal SIGINT, Interrupt\\.\r\n" { >> pass $gdb_test_name >> } >> } >> >> The problem here is that the first interrupt will trigger the prompt >> to be printed, and then, after some time the inferior will be >> interrupted. >> >> However the default pattern for gdb_test includes a '$' end anchor. >> If expect see the prompt with nothing following it then everything is > > Hi Andrew, > > see -> sees > >> fine, and the test passes. >> >> However, if the interrupt is quick and so what expect sees is this: >> >> (gdb) >> Program received signal SIGINT, Interrupt. >> 0x00007ffff7d501e7 in nanosleep () from /lib64/libc.so.6 >> >> In this case the end anchor means that the gdb_test fails to match, >> and eventually times out. >> >> Fix this by passing -no-prompt-anchor to gdb_test. > > thanks for fixing this. > > LGTM. > > Reviewed-by: Tom de Vries Pushed (with typo fixed). Thanks, Andrew > > Thanks, > - Tom > > >> --- >> gdb/testsuite/gdb.server/multi-ui-errors.exp | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/gdb/testsuite/gdb.server/multi-ui-errors.exp b/gdb/testsuite/gdb.server/multi-ui-errors.exp >> index af83614fe55..47ded35bc86 100644 >> --- a/gdb/testsuite/gdb.server/multi-ui-errors.exp >> +++ b/gdb/testsuite/gdb.server/multi-ui-errors.exp >> @@ -106,7 +106,7 @@ with_spawn_id $gdb_main_spawn_id { >> # Get the gdbserver PID. >> set gdbserver_pid 0 >> with_spawn_id $gdb_main_spawn_id { >> - gdb_test "interrupt" >> + gdb_test -no-prompt-anchor "interrupt" >> >> gdb_test_multiple "" "interrupt arrived" { >> -re "Program received signal SIGINT, Interrupt\\.\r\n" { >> >> base-commit: 389971df23ca74092314dbde1303310a33766ba7