From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy2-pub.mail.unifiedlayer.com (gproxy2-pub.mail.unifiedlayer.com [69.89.18.3]) by sourceware.org (Postfix) with ESMTPS id 51C193858C33 for ; Fri, 17 Mar 2023 22:21:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 51C193858C33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw13.mail.unifiedlayer.com (unknown [10.0.90.128]) by progateway4.mail.pro1.eigbox.com (Postfix) with ESMTP id A22FF1003E9C5 for ; Fri, 17 Mar 2023 22:21:43 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id dISFpbXQKNX2adISFpI16Q; Fri, 17 Mar 2023 22:21:43 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=NMAQR22g c=1 sm=1 tr=0 ts=6414e7f7 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=k__wU0fu6RkA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=vCs6fbYx1-hkvqhmSesA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=73LW5VtFJKsCMQS2SWNJCHK/4JV2WbfhLpTmLSK6p/s=; b=TMVNjLqZ5Wm014iFI0mbBqsCLM N8FWoSCb9DLOT50yc79fIEEke6PfT40oLSwBZFn3XLdaLsGF4cisDJ+jdte9oWsa4KbkU1k6zakNc 8n+xaC2SxhNhebfmY7aqja6Il; Received: from 71-211-185-113.hlrn.qwest.net ([71.211.185.113]:52628 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pdISF-003xsh-98; Fri, 17 Mar 2023 16:21:43 -0600 From: Tom Tromey To: Tom Tromey Cc: Simon Marchi , Simon Marchi via Gdb-patches Subject: Re: [PATCH 2/5] Change linetables to be objfile-independent References: <20230308-submit-constify-linetable-v1-0-ca4057478141@tromey.com> <20230308-submit-constify-linetable-v1-2-ca4057478141@tromey.com> <87jzzne1vo.fsf@tromey.com> <87fsaaejnb.fsf@tromey.com> <87y1nwiyk2.fsf@tromey.com> <7ef34f41-d90a-8173-b0b8-08a19b0b4484@simark.ca> <87bkkscled.fsf@tromey.com> <0a02e351-0b13-c3b0-f324-b8e71ea44a7b@simark.ca> <877cvfcynt.fsf@tromey.com> X-Attribution: Tom Date: Fri, 17 Mar 2023 16:21:39 -0600 In-Reply-To: <877cvfcynt.fsf@tromey.com> (Tom Tromey's message of "Fri, 17 Mar 2023 07:09:26 -0600") Message-ID: <87r0tnauj0.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.185.113 X-Source-L: No X-Exim-ID: 1pdISF-003xsh-98 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-185-113.hlrn.qwest.net (prentzel) [71.211.185.113]:52628 X-Source-Auth: tom+tromey.com X-Email-Count: 9 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3017.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_ABUSEAT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tom> #1 Renaming is fine but the "_raw" name was chosen to match psymtabs. Well, I have this partly wrong, sorry about that. psymbols themselves use the other name: CORE_ADDR unrelocated_address () const but psymtabs use: CORE_ADDR raw_text_low () const CORE_ADDR raw_text_high () const and so do minsyms: CORE_ADDR value_raw_address () const I think one set or the other should be renamed. Which one do you prefer? I could go either way. Anyway let me know and I'll rename stuff. Tom