From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd33.google.com (mail-io1-xd33.google.com [IPv6:2607:f8b0:4864:20::d33]) by sourceware.org (Postfix) with ESMTPS id 406053858C83 for ; Thu, 2 Mar 2023 15:50:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 406053858C83 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-io1-xd33.google.com with SMTP id e11so3283144ioe.3 for ; Thu, 02 Mar 2023 07:50:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1677772231; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=+7VRjK1xz97MkFS5fBhMIZs8SnJ8sY9VCRHFLMV8oqk=; b=hJyVhP4tVHc9asBToX7m/A0X7psWYqr/pFM2XUUYxfnfOj2awcoFrgTaN2IN29etHc lsma9v6CfTmO4yoaXRbwSSLQ4P7ssZ2wDhNq2zCe5y//WthGUFTa0yPHi6fvWypaND4T NeU+qAD6cg/XpuCMCUagD2ODSlZPESxhu8iX/rzvbHaQzqldTZFZPPF6h8TPAuCwGcEA ggNLN/hJ7dVQSr60Dm0zCZI/TFoaJ6aukEG2bi8QFGl19SW2xUAHeMHlAYu0ssu9oKYK jz6oV9oAL4Viwk30rh6UcglA+qtG9BZz/Cg5VC+08Pe4vTl4yTue0x3HqT9XnJn4sM/9 0UXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677772231; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+7VRjK1xz97MkFS5fBhMIZs8SnJ8sY9VCRHFLMV8oqk=; b=PHJUgUDTRJBsZ02Uh+3cIoY1TMsnmSMHJy3exKaVG+LddlUy8CjdfFlhpHC3p3DwLz D6irl5rtMpo0qtcQZUrAS9ORSixJ0kK7Z4tYmFfIZ80T/0OpUz3b+7lgcjdkE6Z3oieQ wyKgNkk54xJ2xM2hOU3l3Jvz3b7oiXYP5sa2sEBCbdSbuhBjWXvpZWj0auC8Am4qbNI8 A0rD+OYuRRPs/aJMZpQVH4Rgqhl53Q2Ic1KhzMjeX0AedbHHRMgqrK5EoRWvD0ckbhZP 44SRG3UQxdXtju4FOPKg0XT5Hml1zfvxn3jDLo9HkBWzB3JA50zwvGD5r9ZP9VJiKy/k 29Mg== X-Gm-Message-State: AO0yUKV4timq5gIHxgd1rTUBqzGdQGxhzXwaInry9CyWJRw+Qrl8naEm RERPKx+qEwBA19442UiYAjO/uAc+93loE1i5 X-Google-Smtp-Source: AK7set8mKHgH2mzPDMKMhKYxrmwl5uiTKyw9nGRJAlzGFe0UbUX/FM9aX961xgd2KcHGbjg5NmWN7Q== X-Received: by 2002:a5d:97c3:0:b0:74c:8a53:d07a with SMTP id k3-20020a5d97c3000000b0074c8a53d07amr6360417ios.16.1677772230962; Thu, 02 Mar 2023 07:50:30 -0800 (PST) Received: from murgatroyd (75-166-130-93.hlrn.qwest.net. [75.166.130.93]) by smtp.gmail.com with ESMTPSA id s21-20020a5e9815000000b00746c717e922sm4885944ioj.43.2023.03.02.07.50.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Mar 2023 07:50:30 -0800 (PST) From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] Handle half-float in 'x' command References: <20230224163834.2675084-1-tromey@adacore.com> <58b76ee1-d004-14a3-a47e-2108e5aa7e62@simark.ca> X-Attribution: Tom Date: Thu, 02 Mar 2023 08:50:29 -0700 In-Reply-To: <58b76ee1-d004-14a3-a47e-2108e5aa7e62@simark.ca> (Simon Marchi's message of "Wed, 1 Mar 2023 21:21:52 -0500") Message-ID: <87r0u7b1a2.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Simon" == Simon Marchi writes: Simon> Can you add a comment before the section you added, to indicate what it Simon> intends to test? Simon> Otherwise, that LGTM: Simon> Approved-By: Simon Marchi Simon> Simon Tom