From: Andrew Burgess <aburgess@redhat.com>
To: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>,
gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@polymtl.ca>
Subject: Re: [PATCH v3 00/10] Add typing annotations to gdbarch*.py and make-target-delegates.py
Date: Mon, 27 Feb 2023 17:38:17 +0000 [thread overview]
Message-ID: <87r0ubhuuu.fsf@redhat.com> (raw)
In-Reply-To: <20230227011403.612304-1-simon.marchi@polymtl.ca>
Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
> This is v3 of:
>
> https://inbox.sourceware.org/gdb-patches/20230225033047.373899-2-simon.marchi@polymtl.ca/T/#mc1d1b386fd1235edb2a331dd0a321cf703a3e67b
>
> Changes are:
>
> - In "gdb: split gdbarch component types to gdbarch_types.py", I had
> introduced one typing annotation by mistake. It should have been in
> the following commit. That is fixed now.
> - For container types (lists and dicts), use the types from the typing
> module, to be compatible with Pythons < 3.9.
Tested this with my crusty old Python (3.7.9) and can confirm that this
all now runs fine, I see no changes in the generated files after running
your updated gdbarch.py script.
This all LGTM.
Reviewed-By: Andrew Burgess <aburgess@redhat.com>
Thanks,
Andrew
>
>
> Simon Marchi (10):
> gdb: remove invalid / dead code from gdbarch.py
> gdb: reformat Python files with black 23.1.0
> gdb: gdbarch.py: spell out parameters of _Component.__init__
> gdb: gdbarch.py: remove Info.__init__
> gdb: pyproject.toml: set pyright typeCheckingMode = "strict"
> gdb: split gdbarch component types to gdbarch_types.py
> gdb: gdbarch*.py, copyright.py: add type annotations
> gdb: make-target-delegates.py: make one string raw
> gdb: make-target-delegates.py: add Entry type
> gdb: make-target-delegates.py: add type annotations
>
> gdb/gdbarch.py | 161 +--------------
> ...ch-components.py => gdbarch_components.py} | 7 +-
> gdb/gdbarch_types.py | 184 ++++++++++++++++++
> gdb/gdbcopyright.py | 2 +-
> gdb/make-target-delegates.py | 104 +++++++---
> gdb/pyproject.toml | 3 +
> gdb/python/lib/gdb/FrameDecorator.py | 1 -
> gdb/python/lib/gdb/command/frame_filters.py | 1 +
> gdb/python/lib/gdb/dap/server.py | 2 +-
> gdb/python/lib/gdb/printing.py | 2 +-
> .../gdb.multi/multi-target-info-inferiors.py | 1 +
> gdb/testsuite/gdb.perf/backtrace.py | 1 -
> .../gdb.python/py-framefilter-addr.py | 1 +
> gdb/testsuite/gdb.python/py-framefilter.py | 1 +
> gdb/testsuite/gdb.python/py-inferior-leak.py | 2 +
> gdb/testsuite/gdb.python/py-prettyprint.py | 1 +
> gdb/testsuite/gdb.python/py-recurse-unwind.py | 5 -
> gdb/testsuite/gdb.python/py-send-packet.py | 1 +
> gdb/testsuite/gdb.python/tui-window.py | 1 +
> 19 files changed, 284 insertions(+), 197 deletions(-)
> rename gdb/{gdbarch-components.py => gdbarch_components.py} (99%)
> create mode 100755 gdb/gdbarch_types.py
>
>
> base-commit: 95ebc6fdec5780bf59685739cdd55cd41d0f55ac
> --
> 2.39.2
next prev parent reply other threads:[~2023-02-27 17:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-27 1:13 Simon Marchi
2023-02-27 1:13 ` [PATCH v3 01/10] gdb: remove invalid / dead code from gdbarch.py Simon Marchi
2023-02-27 1:13 ` [PATCH v3 02/10] gdb: reformat Python files with black 23.1.0 Simon Marchi
2023-02-27 1:13 ` [PATCH v3 03/10] gdb: gdbarch.py: spell out parameters of _Component.__init__ Simon Marchi
2023-02-27 1:13 ` [PATCH v3 04/10] gdb: gdbarch.py: remove Info.__init__ Simon Marchi
2023-02-27 1:13 ` [PATCH v3 05/10] gdb: pyproject.toml: set pyright typeCheckingMode = "strict" Simon Marchi
2023-02-27 1:13 ` [PATCH v3 06/10] gdb: split gdbarch component types to gdbarch_types.py Simon Marchi
2023-02-27 1:14 ` [PATCH v3 07/10] gdb: gdbarch*.py, copyright.py: add type annotations Simon Marchi
2023-02-27 1:14 ` [PATCH v3 08/10] gdb: make-target-delegates.py: make one string raw Simon Marchi
2023-02-27 1:14 ` [PATCH v3 09/10] gdb: make-target-delegates.py: add Entry type Simon Marchi
2023-02-27 1:14 ` [PATCH v3 10/10] gdb: make-target-delegates.py: add type annotations Simon Marchi
2023-02-27 17:38 ` Andrew Burgess [this message]
2023-02-27 18:27 ` [PATCH v3 00/10] Add typing annotations to gdbarch*.py and make-target-delegates.py Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0ubhuuu.fsf@redhat.com \
--to=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).