From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 337D03858004 for ; Fri, 13 Jan 2023 16:42:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 337D03858004 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673628157; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CEeAfmPqF0zP3aD/SPrjHpBac5NoUBYv3GURyB0AG4k=; b=K6f8vIdgxbbIXmB57W5CDW11+H5G+81k0BK3gFHtIc8HMjeTehmAMCahpFhIrDaeBDYHCl MwEtPUvXUHlxieqj78lCf6CHvBXXszzOUdElAptuaWIIxICZhPZXX84scO18KQd4dLY0QN +iLv095m0SdVzijeLIzuua0kDCGbVnk= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-67-hAjFc6KvMTCkC2Rzi2fZJg-1; Fri, 13 Jan 2023 11:42:36 -0500 X-MC-Unique: hAjFc6KvMTCkC2Rzi2fZJg-1 Received: by mail-wm1-f70.google.com with SMTP id t24-20020a1c7718000000b003d1fd0b866fso5076640wmi.3 for ; Fri, 13 Jan 2023 08:42:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CEeAfmPqF0zP3aD/SPrjHpBac5NoUBYv3GURyB0AG4k=; b=GW4dLlIZwQUsXRRNvwQr4+DfzlY9l2juEvYuu469u2W+U57MKJq5IpVs1Z4DEEzaWc LtkFEAlEzPMN7s5c7eorrqelMVkEx0g/XwcFK2i7NaomK5cqXXmjivorR262FLmp8X+z kA3VyMDdK3GpZUHfkOvz7ZVLSfqrC7F+DFRRoTOoCYdHbYBopQ3rPjNC993z+2Wdv2vG ETjzQQHwTJDNup+Bla7TCYey+lwQ8L+LtZu78Mb2nW/jecSyG+5AZ1fcwTP9zIadTGbj 0tGDqGiMZkb92rvvasq1iDdmpVLKNgVBDIYWw6+nAU/8W/JVD5FnHygPISMrepo3vfB4 Wxdw== X-Gm-Message-State: AFqh2kqBfpb6SpVa28z6t8cmCVgSp+ltVoHJ93gvEi/qhkrwY/HebX4k 1grM3ZHkY+8FZ5wZUdOyMm8FEVWsdYwnhQLb/hiNitHMrlYa932ws9GczEMXzqlIAMwZ+LCm+/o atZ4URemg8ZxtM+bQ2cqaIJ/+KmT7peMBg8rSPhRBjhD8mzuFYojVy6fGHFPHcicOFoGrR5VXCA == X-Received: by 2002:a05:600c:358f:b0:3d1:cdf7:debf with SMTP id p15-20020a05600c358f00b003d1cdf7debfmr60493475wmq.26.1673628155416; Fri, 13 Jan 2023 08:42:35 -0800 (PST) X-Google-Smtp-Source: AMrXdXtkJKrSDb+1WXfhakfp0zEGEuw2IRHNFlNkJRpBINiuooSn2Ifrf76e4/7PpIPcErhBz0rE0A== X-Received: by 2002:a05:600c:358f:b0:3d1:cdf7:debf with SMTP id p15-20020a05600c358f00b003d1cdf7debfmr60493464wmq.26.1673628155183; Fri, 13 Jan 2023 08:42:35 -0800 (PST) Received: from localhost (95.72.115.87.dyn.plus.net. [87.115.72.95]) by smtp.gmail.com with ESMTPSA id y6-20020a1c4b06000000b003da119d7251sm6198427wma.21.2023.01.13.08.42.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jan 2023 08:42:34 -0800 (PST) From: Andrew Burgess To: gdb-patches@sourceware.org Subject: Re: [PATCH 04/12] gdbserver: add comments to read_inferior_memory function In-Reply-To: References: Date: Fri, 13 Jan 2023 16:42:33 +0000 Message-ID: <87r0vyfksm.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Andrew Burgess writes: > Just adding some comments to the gdbserver read_inferior_memory > function. No actual code changes. I've gone ahead and pushed this. I'm reasonably sure the comments I've added are correct, I'm happy to update them if anyone disagrees. Thanks, Andrew > --- > gdbserver/target.cc | 2 ++ > gdbserver/target.h | 3 +++ > gdbserver/tracepoint.cc | 2 ++ > 3 files changed, 7 insertions(+) > > diff --git a/gdbserver/target.cc b/gdbserver/target.cc > index adcfe6e7bcc..6b29c99a61b 100644 > --- a/gdbserver/target.cc > +++ b/gdbserver/target.cc > @@ -79,6 +79,8 @@ set_desired_process () > return proc != nullptr; > } > > +/* See target.h. */ > + > int > read_inferior_memory (CORE_ADDR memaddr, unsigned char *myaddr, int len) > { > diff --git a/gdbserver/target.h b/gdbserver/target.h > index 6c536a30778..a49d7d4bac0 100644 > --- a/gdbserver/target.h > +++ b/gdbserver/target.h > @@ -697,6 +697,9 @@ target_thread_pending_child (thread_info *thread) > return the_target->thread_pending_child (thread); > } > > +/* Read LEN bytes from MEMADDR in the buffer MYADDR. Return 0 if the read > + is successful, otherwise, return a non-zero error code. */ > + > int read_inferior_memory (CORE_ADDR memaddr, unsigned char *myaddr, int len); > > /* Set GDBserver's current thread to the thread the client requested > diff --git a/gdbserver/tracepoint.cc b/gdbserver/tracepoint.cc > index 18b2b0b3d77..efcdfe12beb 100644 > --- a/gdbserver/tracepoint.cc > +++ b/gdbserver/tracepoint.cc > @@ -344,6 +344,8 @@ tracepoint_look_up_symbols (void) > GDBserver side. */ > > #ifdef IN_PROCESS_AGENT > +/* See target.h. */ > + > int > read_inferior_memory (CORE_ADDR memaddr, unsigned char *myaddr, int len) > { > -- > 2.25.4