From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 45719385840C for ; Mon, 24 Oct 2022 15:45:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 45719385840C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666626332; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=81R1Olvp1P+qzftR2e5s5vSiwHJbDC5JF9hE/Oi+M1g=; b=DtTxmqJHHlo2JFp516Uox+gP6BiklDBZ4x9znb7YwKZbANs/cDOrlfPVGkXlcfppiY1f/q 5160dNoaXLaO53xPOkXPk06p9m2eoB9WjuVXD4sYm6irh1SKSWbJTU57utgdxcIgzashfa Fl24S1sopL5Dx0f1yGQ5WWzzUSA8lwM= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-16-dFNS1-0oO1yUgA5LA_-Yvg-1; Mon, 24 Oct 2022 11:45:31 -0400 X-MC-Unique: dFNS1-0oO1yUgA5LA_-Yvg-1 Received: by mail-qv1-f70.google.com with SMTP id mo15-20020a056214330f00b004b96d712bccso5473178qvb.22 for ; Mon, 24 Oct 2022 08:45:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=81R1Olvp1P+qzftR2e5s5vSiwHJbDC5JF9hE/Oi+M1g=; b=WbTGDlSJIlo+7T4rLnzkx+/bD3DEU2kWDOtbKI+QuiUQL0t/QgrrwuKxIQLQwe8Vja Tt/xYL783vOxO4AGHDX2S8buKnwv8jx1/NofrxviLWGlO9qbZZgKLAz33hli6pF3BGhV yTjUit2PrbChkoI+ysbIdtcbDFbULge+KGKmCR5uH7+EK9t7hnP24dfhKnWp9388psxI ojTG5LNEKWhiTQcpJrRUkUhicnsUIk1cVMPO4iXlRa2FQY2KAKhDottuYRcoBDc4vnFV xyWPLvLiumkx8Uv7MJz6t1uprdZbpieoKb9OMg7NzS+j1+csZsW7uxwMe5NDP/XD6mg3 rq3w== X-Gm-Message-State: ACrzQf2wSHRIhAsDQC4z8mTWYyqfaFf+E5JxeieqnkzxBoVrnb7YeVwx ++e1Kc0i8CtHRoVV0Ocmnch+SQs3RBKac4MxtY5930iexGJvoSB8UdiMgd4CHjHqgjGbHiGReyh DuMN/nlUg6hdEVj0yPn7eqw== X-Received: by 2002:ac8:5a8e:0:b0:39c:c815:76ec with SMTP id c14-20020ac85a8e000000b0039cc81576ecmr27391945qtc.508.1666626331247; Mon, 24 Oct 2022 08:45:31 -0700 (PDT) X-Google-Smtp-Source: AMsMyM78ImqD0840bWuv+MdZPzaqOonndwhoXlIdhpQY8ljr88NPP/wBOpYxmwnxJgQzsL7gG4xkjg== X-Received: by 2002:ac8:5a8e:0:b0:39c:c815:76ec with SMTP id c14-20020ac85a8e000000b0039cc81576ecmr27391924qtc.508.1666626331010; Mon, 24 Oct 2022 08:45:31 -0700 (PDT) Received: from localhost ([31.111.84.238]) by smtp.gmail.com with ESMTPSA id f8-20020ac84708000000b0039c9d0dcaf8sm91550qtp.85.2022.10.24.08.45.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Oct 2022 08:45:30 -0700 (PDT) From: Andrew Burgess To: Mike Frysinger Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 5/5] sim/iq2000: silence pointer-sign warnings In-Reply-To: References: <89f7a81c43e4b9acf725de1668f7754692e6dd83.1665578246.git.aburgess@redhat.com> Date: Mon, 24 Oct 2022 16:45:29 +0100 Message-ID: <87r0yx8bty.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Mike Frysinger writes: > On 12 Oct 2022 13:38, Andrew Burgess via Gdb-patches wrote: >> When building the iq2000 simulator I see a few warnings like this: >>=20 >> /tmp/build/sim/../../src/sim/iq2000/iq2000.c: In function =E2=80=98fet= ch_str=E2=80=99: >> /tmp/build/sim/../../src/sim/iq2000/iq2000.c:50:54: error: pointer tar= gets in passing argument 3 of =E2=80=98sim_read=E2=80=99 differ in signedne= ss [-Werror=3Dpointer-sign] >> 50 | sim_read (CPU_STATE (current_cpu), CPU2DATA(addr), buf, nr); >> | ^~~ >> | | >> | char * >>=20 >> I've silenced these warnings by casting buf to 'unsigned char *'. >> With this change I now see no warnings when compiling iq2000.c, so >> I've removed the line from Makefile.in that disables -Werror. > > i left this warning in place so someone would fix it properly rather than > just cast it away Sorry for not understanding that. If you'd like to expand on "properly" I'll take a pass at fixing it. Thanks, Andrew