From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from qproxy5-pub.mail.unifiedlayer.com (qproxy5-pub.mail.unifiedlayer.com [69.89.21.30]) by sourceware.org (Postfix) with ESMTPS id EC9C33858D28 for ; Mon, 18 Jul 2022 16:17:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EC9C33858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from outbound-ss-761.bluehost.com (outbound-ss-761.bluehost.com [74.220.211.250]) by qproxy5.mail.unifiedlayer.com (Postfix) with ESMTP id EBDA280251A5 for ; Mon, 18 Jul 2022 16:17:04 +0000 (UTC) Received: from cmgw11.mail.unifiedlayer.com (unknown [10.0.90.126]) by progateway8.mail.pro1.eigbox.com (Postfix) with ESMTP id 5E5761004CA72 for ; Mon, 18 Jul 2022 16:16:13 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id DTPooelsLq24iDTPpogWvE; Mon, 18 Jul 2022 16:16:13 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=DaLSFthW c=1 sm=1 tr=0 ts=62d5874d a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=RgO8CyIxsXoA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=5KLPUuaC_9wA:10:nop_rfc2047_subject_charset a=iOeFMeb1XtywMsWKUyEA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=XS03wk145WIRgk6C070ApinQwqrkHHIMYlhyUuG6zCI=; b=VIJG0qmwTvgiRZUzeKKhAlsn0a 8fCNQcqXJQdqxpTEjSB7xPYI/n/agAonrY58aUYmay6VI0TKvTgO84f5H5Sjyk/EgROf0X4LOwk4F 5uAp4VHB4vg4JJmhsVZSZtSVy; Received: from 71-211-185-228.hlrn.qwest.net ([71.211.185.228]:56154 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oDTPo-000Qpi-E7; Mon, 18 Jul 2022 10:16:12 -0600 From: Tom Tromey To: =?utf-8?B?5p2O5rGf5biF?= Cc: "Tom Tromey" , gdb-patches Subject: Re: =?utf-8?Q?Re=EF=BC=9A=5BPATCH=5D?= gdb/csky complete csky_dwarf_reg_to_regnum References: <772531f3-b91d-48e7-8ec4-3587600d97db.jiangshuai_li@c-sky.com> X-Attribution: Tom Date: Mon, 18 Jul 2022 10:16:11 -0600 In-Reply-To: <772531f3-b91d-48e7-8ec4-3587600d97db.jiangshuai_li@c-sky.com> (" =?utf-8?B?5p2O5rGf5biFIidz?= message of "Mon, 18 Jul 2022 10:50:22 +0800") Message-ID: <87r12il7lg.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.185.228 X-Source-L: No X-Exim-ID: 1oDTPo-000Qpi-E7 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-185-228.hlrn.qwest.net (murgatroyd) [71.211.185.228]:56154 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jul 2022 16:17:17 -0000 >>> + if (dw_reg >= CSKY_R0_REGNUM && dw_reg <= (CSKY_R0_REGNUM + 31)) >> >> This line and some others have too many parentheses. > This line meens that "if (dw_reg >=0 && dw_reg <= 31)". As i does not define CSKY_R31_REGNUM, > i wrote 31 as (CSKY_R0_REGNUM + 31). Yeah, what I mean is that there doesn't seem to be a need for the parens in the second comparison. This sort of thing is more the gdb style: if (dw_reg >= CSKY_R0_REGNUM && dw_reg <= CSKY_R0_REGNUM + 31) There are other cases like this: >>> + /* For Float and Vector pseudo registers. */ >>> + if ((dw_reg >= FV_PSEUDO_REGNO_FIRST) && (dw_reg <= FV_PSEUDO_REGNO_LAST)) ... where there are excessive parens. >>> + xsnprintf (name_buf, sizeof (name_buf), "s%d", >>> + dw_reg - FV_PSEUDO_REGNO_FIRST); >>> + return user_reg_map_name_to_regnum (gdbarch, name_buf, >>> + strlen (name_buf)); >> >> This seems like a very roundabout approach. Is there a reason it's done >> this way? > I am not sure what you mean, this code mean that: > if (dw_reg >= 74 && dw_reg <= 201), dw_reg will corresponds to a pseudo register > added for float or vector registers. > Similar code: arm-tdep.c: 4876 What I mean here is that this code looks up the register by name to get its number. But why is this extra step needed? It's fine if it's needed, but I'd like to understand why. Tom