From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 244773858C52 for ; Mon, 4 Jul 2022 10:17:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 244773858C52 Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-102-5d3axX1yNAeiw9cw-N2Ulw-1; Mon, 04 Jul 2022 06:17:50 -0400 X-MC-Unique: 5d3axX1yNAeiw9cw-N2Ulw-1 Received: by mail-wr1-f71.google.com with SMTP id n7-20020adfc607000000b0021a37d8f93aso1347193wrg.21 for ; Mon, 04 Jul 2022 03:17:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version; bh=wtJuJuNWaa1gXLuytqQ3c41kq2uOnW4ooZuB9qrysAs=; b=NXhD9roFHp/TB6awo6xNoFymYvL5uxYC4/p4SWVgI/rfXNFxbPNDtig5VncYwj8+Rj Iaup9xnt0zhXAH3Jm+p+C/QKjK3JgcohXORuEYaU3Dm4GeyLwPtyoyw5DpbRYNpAz6p9 VlQP4W47jtN4eHKjF6Hfq+AaFSgr2WKbp1Htc8X32WHAd8MXa3M9Jba7gOXGvoJVnYOa 8Bag4PqK3OmL4SRobbj41vp7t26V+pznLleC3Sjxqu6+CQ+j3rABRcT0AN7kRQX4tmxx FQE0/0vDHg/OrpmR68szk2kpFTNv0W4tvi15ZqiChIiPBQxotRiS1sRiVgg00w+cVv11 LIig== X-Gm-Message-State: AJIora9tQr5ujV/9QHj4tZre+mRj9j5PZhALwzQzEkx5SyeQeROwITrR qGJdW0bdHnTq4vE6xBKVh98xro7QeBo4F3U5rZ5EPdHt4bSi/wIG6/YyNN8tC+tgiAwSS1RtWfB LjMI1FReqH8ndY3DDyCrhqQKRKMvpIbFJABNtMO9ZbHN5TqJSQ+9Ik3CgoKFKgwh8FoZ7kmNAsg == X-Received: by 2002:adf:ed83:0:b0:21d:6c97:b4 with SMTP id c3-20020adfed83000000b0021d6c9700b4mr2405195wro.205.1656929869284; Mon, 04 Jul 2022 03:17:49 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sl5WTzLNltN3KMFCH6VL6ODpwHsNlsUhu/io6Xy6cH68n6dTUew6f8rVu6MSX96+Ja6SzTqQ== X-Received: by 2002:adf:ed83:0:b0:21d:6c97:b4 with SMTP id c3-20020adfed83000000b0021d6c9700b4mr2405172wro.205.1656929869015; Mon, 04 Jul 2022 03:17:49 -0700 (PDT) Received: from localhost (15.72.115.87.dyn.plus.net. [87.115.72.15]) by smtp.gmail.com with ESMTPSA id c3-20020adfef43000000b0021bab0ba755sm30878999wrp.106.2022.07.04.03.17.48 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Jul 2022 03:17:48 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Subject: Re: [PATCH 0/2] Use libopcodes disassembler styling with GDB In-Reply-To: References: Date: Mon, 04 Jul 2022 11:17:47 +0100 Message-ID: <87r131b2r8.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Jul 2022 10:17:53 -0000 Ping! Unless somebody objects, I plan to push this series later this week. The libopcodes styling support is already in-tree (via binutils), and I feel the changes in these patches are a fairly obvious extension to GDB to make use of this additional information. As always, feedback is always welcome. Thanks, Andrew Andrew Burgess writes: > libopcodes is slowly gaining the ability to provide styling > information for its disassembler output. > > This series extends GDB to make use of this information where possible > (currently only i386 based architectures and RISC-V). > > --- > > Andrew Burgess (2): > gdb: have gdb_disassemble_info carry 'this' in its stream pointer > gdb: add support for disassembler styling using libopcodes > > gdb/NEWS | 28 ++++++ > gdb/cli/cli-style.c | 107 ++++++++++++++++++++-- > gdb/cli/cli-style.h | 28 ++++-- > gdb/disasm.c | 217 +++++++++++++++++++++++++++++++++++++++++--- > gdb/disasm.h | 81 ++++++++++++----- > gdb/doc/gdb.texinfo | 100 +++++++++++++++++++- > 6 files changed, 503 insertions(+), 58 deletions(-) > > -- > 2.25.4